Fixed #392 : Added an option to disable SSH key decryption progress bar

KeeAgent/ExtensionMethods.cs

@@ -362,7 +362,7 @@ static byte[] GetPassphrase(this PwEntry entry)
       return Encoding.UTF8.GetBytes(passphrase);
     }
 
-    public static ISshKey GetSshKey(this PwEntry entry)
+    public static ISshKey GetSshKey(this PwEntry entry, KeeAgentExt ext)
     {
       var settings = entry.GetKeeAgentSettings();
 
@@ -381,7 +381,7 @@ public static ISshKey GetSshKey(this PwEntry entry)
       AsymmetricKeyParameter parameter;
       var comment = string.Empty;
 
-      if (privateKey.HasKdf) {
+      if (privateKey.HasKdf && !ext.Options.DisableKeyDecryptionProgressBar) {
         // if there is a key derivation function, decrypting could be slow,
         // so show a progress dialog
         var dialog = new DecryptProgressDialog();

KeeAgent/KeeAgentExt.cs

@@ -63,6 +63,7 @@ public sealed partial class KeeAgentExt : Plugin
     const string userPicksKeyOnRequestIdentitiesOptionName =
       pluginNamespace + ".UserPicksKeyOnRequestIdentities";
     const string ignoreMissingExternalKeyFilesName = pluginNamespace + ".IgnoreMissingExternalKeyFilesName";
+    const string disableKeyDecryptionProgressBarName = pluginNamespace + ".DisableKeyDecryptionProgressBar";
     const string keyFilePathSprPlaceholder = @"{KEEAGENT:KEYFILEPATH}";
     const string identFileOptSprPlaceholder = @"{KEEAGENT:IDENTFILEOPT}";
     const string groupMenuItemName = "KeeAgentGroupMenuItem";
@@ -621,6 +622,7 @@ internal void SaveGlobalOptions()
       config.SetBool(userPicksKeyOnRequestIdentitiesOptionName,
         Options.UserPicksKeyOnRequestIdentities);
       config.SetBool(ignoreMissingExternalKeyFilesName, Options.IgnoreMissingExternalKeyFiles);
+      config.SetBool(disableKeyDecryptionProgressBarName, Options.DisableKeyDecryptionProgressBar);
     }
 
     private void LoadOptions()
@@ -643,6 +645,7 @@ private void LoadOptions()
       Options.UserPicksKeyOnRequestIdentities =
         config.GetBool(userPicksKeyOnRequestIdentitiesOptionName, false);
       Options.IgnoreMissingExternalKeyFiles = config.GetBool(ignoreMissingExternalKeyFilesName, false);
+      Options.DisableKeyDecryptionProgressBar = config.GetBool(disableKeyDecryptionProgressBarName, false);
 
       string defaultLogFileNameValue = Path.Combine(
           Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
@@ -1053,7 +1056,7 @@ private void SprEngine_FilterCompile(object sender, SprEventArgs e)
       var settings = entry.GetKeeAgentSettings();
 
       try {
-        var key = entry.GetSshKey();
+        var key = entry.GetSshKey(this);
         string db_name = "<Unknown database>";
 
         try {

KeeAgent/Options.cs

@@ -107,5 +107,10 @@ public Options()
     /// in the filesystem.
     /// </summary>
     public static bool IgnoreMissingExternalKeyFiles { get; set; }
+
+    /// <summary>
+    /// When <c>true</c>, we will not display a progress bar during SSH key decryption.
+    /// </summary>
+    public bool DisableKeyDecryptionProgressBar { get; set; }
   }
 }

KeeAgent/Translatable.resx

@@ -209,6 +209,9 @@
   <data name="OptionIgnoreMissingExternalKeyFiles" xml:space="preserve">
     <value>Ignore entries with missing external key files when automatically loading keys</value>
   </data>
+  <data name="OptionDisableKeyDecryptionProgressBar" xml:space="preserve">
+    <value>Disable SSH key decryption progress bar</value>
+  </data>
   <data name="LoadKeyOpenUrlContextMenuItem" xml:space="preserve">
     <value>Load SS&amp;H Key and Open URL</value>
   </data>

KeeAgent/UI/OptionsPanel.cs

@@ -62,6 +62,8 @@ public OptionsPanel(KeeAgentExt ext)
       customListViewEx.Groups.Add(optionsGroup);
       optionsList.CreateItem(ext.Options, "IgnoreMissingExternalKeyFiles",
         optionsGroup, Translatable.OptionIgnoreMissingExternalKeyFiles);
+      optionsList.CreateItem(ext.Options, "DisableKeyDecryptionProgressBar",
+        optionsGroup, Translatable.OptionDisableKeyDecryptionProgressBar);
 
       var agentModeOptionsGroup = new ListViewGroup("agentMode",
                           "Agent Mode Options (no effect in Client Mode)");

doc/usage/options.rst

@@ -44,6 +44,10 @@ tab.
         external key files linked to password entries are missing. This option
         is useful when you use the same KeePass database on multiple computers.
 
+
+    -   **Disable SSH key decryption progress bar**: (default: disabled) Do not
+        show a progress bar during SSH key decryption process.
+
 **Agent Mode Options** (no effect in *Client* mode)
 
     These options only affect KeeAgent when running in *Agent* mode.