Not catching AgentFailureException in client mode

[dlech]

[markschuh]

Same error here (using KeeAgent Beta 0.3.3 inside KeePass 2.20.1, pageant v0.62)

Exception only occurs if an already existing key is added to pageant..

Looks as if pageant answers with SSH_AGENT_FAILURE in case the key is already loaded.

lines 1089-1096 from WINDOWS\WINPGNT.C in putty v0.62 sources:
ret[4] = SSH_AGENT_FAILURE;
if (add234(rsakeys, key) == key) {
keylist_update();
ret[4] = SSH_AGENT_SUCCESS;
} else {
freersakey(key);
sfree(key);
}

[dlech]

@markschuh You are exactly correct. All I can do is get a better error message and point this out in the documentation.

[markschuh]

Fair enough, a valid solution for this isue. It is probably only a corner case.
I personally only stumbled over this issue during migration from Pageant to KeeAgent. I really appreciate KeeAgent!

On the other side: As an enhancement request it might work, if first GetAllKeys is executed, I assume it could than be checked, if the new key is already in this list. If yes, AddKey could be skipped. Might introduce new problems, though.

[dlech]

Should be fixed now.