-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #392 : Added an option to disable SSH key decryption progress bar #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This looks good. Just a couple of suggestions.
KeeAgent/ExtensionMethods.cs
Outdated
@@ -362,7 +362,7 @@ static byte[] GetPassphrase(this PwEntry entry) | |||
return Encoding.UTF8.GetBytes(passphrase); | |||
} | |||
|
|||
public static ISshKey GetSshKey(this PwEntry entry) | |||
public static ISshKey GetSshKey(this PwEntry entry, KeeAgentExt ext) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing the entire extension, can we just have a boolean parameter for enabling/disabling UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlech , sure
@@ -44,6 +44,10 @@ tab. | |||
external key files linked to password entries are missing. This option | |||
is useful when you use the same KeePass database on multiple computers. | |||
|
|||
|
|||
- **Disable SSH key decryption progress bar**: (default: disabled) Do not | |||
show a progress bar during SSH key decryption process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be helpful to mention that the UI will still be frozen/unresponsive while the keys are being decrypted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dlech , done
…of a simple bool option
…f the new option
Fix for #392
![Screenshot_33](https://private-user-images.githubusercontent.com/35864862/272975987-be897586-08e3-46ab-be0c-f90f2dabcc18.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM2ODMyMDQsIm5iZiI6MTcyMzY4MjkwNCwicGF0aCI6Ii8zNTg2NDg2Mi8yNzI5NzU5ODctYmU4OTc1ODYtMDhlMy00NmFiLWJlMGMtZjkwZjJkYWJjYzE4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODE1VDAwNDgyNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI3ZDk1YzBmMDY5ZjQzMmRmMjkzMTRkOTMzYTNhMDg1YWY0MjJkYWZkNzExZjk0MGU2ZjNmNmVhZjhiYzNmMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.r3pBpU3Y_VJDBkRYJfO-d9h0pMPtRSnaGPN6Nuw8EoI)
Added an option to disable SSH key decryption progress bar: