Fixed #392 : Added an option to disable SSH key decryption progress bar #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Oct 6, 2023
KeeAgent/ExtensionMethods.cs
Outdated
| @@ -362,7 +362,7 @@ static byte[] GetPassphrase(this PwEntry entry) | |||
| return Encoding.UTF8.GetBytes(passphrase); | |||
| } | |||
|
|
|||
| public static ISshKey GetSshKey(this PwEntry entry) | |||
| public static ISshKey GetSshKey(this PwEntry entry, KeeAgentExt ext) | |||
There was a problem hiding this comment.
Instead of passing the entire extension, can we just have a boolean parameter for enabling/disabling UI?
| @@ -44,6 +44,10 @@ tab. | |||
| external key files linked to password entries are missing. This option | |||
| is useful when you use the same KeePass database on multiple computers. | |||
|
|
|||
|
|
|||
| - **Disable SSH key decryption progress bar**: (default: disabled) Do not | |||
| show a progress bar during SSH key decryption process. | |||
There was a problem hiding this comment.
I think it would be helpful to mention that the UI will still be frozen/unresponsive while the keys are being decrypted.
…of a simple bool option
…f the new option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #392
Added an option to disable SSH key decryption progress bar: