Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinGW and MinGW-w64 builds to AppVeyor (take 2) #48

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

traversaro
Copy link
Collaborator

@traversaro traversaro commented Feb 10, 2019

Based on #46 .

@traversaro traversaro changed the title New take at mingw on appveyor Add MinGW and MinGW-w64 builds to AppVeyor (take 2) Feb 11, 2019
.appveyor.yml Outdated
@@ -138,6 +138,7 @@ before_build:
- set PATH=%PATH:C:\Program Files\Git\usr\bin;=%
- set PATH=C:\MinGW\bin;%PATH%
- if /I "%GENERATOR%" == "MinGW Makefiles" (set "GENERATOR_ARGS=") else (set "GENERATOR_ARGS=-A %PLATFORM%")
- if /I "%GENERATOR%" == "MinGW Makefiles" (set "INSTALL_TARGET=install") else (set "INSTALL_TARGET=INSTALL")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that lowercase install does not work with MSVC?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 56c6cbc .

.appveyor.yml Outdated
@@ -134,10 +134,13 @@ matrix:
CMAKE_PREFIX_PATH: "C:\\mingw-w64\\x86_64-7.2.0-posix-seh-rt_v5-rev1"

before_build:
- set Path=C:\\MinGW\\bin;%Path%
# See https://help.appveyor.com/discussions/problems/3193-cmake-building-for-mingw-issue-with-git-shexe
- set PATH=%PATH:C:\Program Files (x86)\Git\bin;=%
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is more elegant solution as my original which renamed sh.exe.

Similar problem I had with building C module for Perl as on AppVeyor are 3 different perl versions and 2 different MinGW versions which Perl can detect. And I just renamed binaries...:
perl5-dbi/DBD-MariaDB@97d28bb#diff-180360612c6b8c4ed830919bbb4dd459R36

.appveyor.yml Outdated
BUILD_SHARED_LIBS: OFF

- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
GENERATOR: "MinGW Makefiles"
CMAKE_PREFIX_PATH: "C:\\mingw-w64\\i686-5.3.0-posix-dwarf-rt_v4-rev0"
cc_path: "C:\mingw-w64\i686-5.3.0-posix-dwarf-rt_v4-rev0\mingw32\bin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is yaml string, so backslash in double quotes needs to be escaped... "C:\\mingw-"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in the later commit: 6fda813 .

@traversaro
Copy link
Collaborator Author

@pali If AppVeyor is happy and you approve the PR, I think I can squash it an merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants