Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][io] KCA: 'desanitize' topic name for the pulsar's ctx calls #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlg99
Copy link
Owner

@dlg99 dlg99 commented Mar 8, 2023

Motivation

Some kafka connectors use topic name to e.g. create table names but pulsar's topic URI does not comply with requirements of the table names. This problems either handled by the connector or by KCA if sanitizeTopicName is set to true.
Some kafka connectors use pause/resume API, in that case sanitized name has to be converted back to original URI to pass to Pulsar's components.

Modifications

Provided a way to resolve original topic URI.

Added unit test.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added unit test.

Does this pull request potentially affect one of the following parts:

NO

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dlg99 dlg99 changed the title KCA: 'desanitize' topic name for the pulsar's ctx calls [fix][pulsar-io] KCA: 'desanitize' topic name for the pulsar's ctx calls Mar 8, 2023
@dlg99 dlg99 changed the title [fix][pulsar-io] KCA: 'desanitize' topic name for the pulsar's ctx calls [fix][io] KCA: 'desanitize' topic name for the pulsar's ctx calls Mar 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant