Fixes #205

dlidstrom · Sep 22, 2019 · 5d498b4 · 5d498b4
1 parent 752f908
commit 5d498b4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 25 deletions.
diff --git a/MinaGlosor.Web/Controllers/AccountInviteController.cs b/MinaGlosor.Web/Controllers/AccountInviteController.cs
@@ -15,7 +15,12 @@ public ActionResult Invite(RequestCreateAccount request)
             {
                 ModelState.AddModelError("Request", "Invalid request");
             }
-            else if (ExecuteQuery(new GetUserByEmailQuery(request.UserEmail)) != null)
+            else if (string.IsNullOrWhiteSpace(request.UserEmail) == false)
+            {
+                // try to catch the spammers
+                return RedirectToAction("Index", "Home");
+            }
+            else if (ExecuteQuery(new GetUserByEmailQuery(request.UserEmail2)) != null)
             {
                 ModelState.AddModelError("Email", "E-postadressen finns redan");
             }
@@ -36,8 +41,10 @@ public ActionResult InviteSuccess()
 
         public class RequestCreateAccount
         {
-            [Required, MaxLength(254)]
             public string UserEmail { get; set; }
+
+            [Required, MaxLength(254)]
+            public string UserEmail2 { get; set; }
         }
     }
 }
diff --git a/MinaGlosor.Web/MinaGlosor.Web.csproj b/MinaGlosor.Web/MinaGlosor.Web.csproj
@@ -293,7 +293,6 @@
     <None Include="NLog.xsd">
       <SubType>Designer</SubType>
     </None>
-    <None Include="Properties\PublishProfiles\MinaGlosor-Netcetera.pubxml" />
     <Content Include="Views\Emails\InviteUser.cshtml" />
     <Content Include="Views\ResetPassword\Reset.cshtml" />
     <Content Include="Views\Emails\ResetPassword.cshtml" />

diff --git a/MinaGlosor.Web/Properties/PublishProfiles/MinaGlosor-Netcetera.pubxml b/MinaGlosor.Web/Properties/PublishProfiles/MinaGlosor-Netcetera.pubxml
diff --git a/MinaGlosor.Web/Views/Home/RegisterOrLogin.cshtml b/MinaGlosor.Web/Views/Home/RegisterOrLogin.cshtml
@@ -9,6 +9,8 @@
 </p>
 <form method="POST" name="inviteform" action="@Url.Action("Invite", "AccountInvite")">
     @Html.DisplayFor(model => Html.ViewData.ModelState, "ValidationSummary")
+    @* try to catch the spammers *@
+    <input style="display: none;" type="email" class="form-control" placeholder="Lämna den här tom" name="useremail" />
     <div class="row">
         <div class="col-md-4">
             <div class="form-group" ng-class="{'has-error': inviteform.useremail.$dirty && inviteform.useremail.$invalid}">
@@ -17,7 +19,7 @@
                 </label>
                 <input type="email"
                        class="form-control"
-                       name="useremail"
+                       name="useremail2"
                        ng-model="user.email"
                        placeholder="Skriv e-postadress"
                        autofocus="autofocus"