Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on new version 2.3.0 #473

Closed
lughino opened this issue Apr 21, 2016 · 5 comments
Closed

Error on new version 2.3.0 #473

lughino opened this issue Apr 21, 2016 · 5 comments

Comments

@lughino
Copy link

lughino commented Apr 21, 2016

Hi,
I get this error when I launch the task:

/var/www/test/node_modules/node-sass/lib/index.js:180
  options.includePaths = (options.includePaths || []).join(path.delimiter);
                                                      ^

TypeError: (options.includePaths || []).join is not a function
    at getOptions (/var/www/test/node_modules/node-sass/lib/index.js:180:55)
    at Object.module.exports.render (/var/www/test/node_modules/node-sass/lib/index.js:267:13)
    at DestroyableTransform._transform (/var/www/test/node_modules/gulp-sass/index.js:138:25)
    at DestroyableTransform.Transform._read (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:159:10)
    at DestroyableTransform.Transform._write (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:147:83)
    at doWrite (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:313:64)
    at writeOrBuffer (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:302:5)
    at DestroyableTransform.Writable.write (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:241:11)
    at DestroyableTransform.ondata (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:531:20)
    at emitOne (events.js:77:13)
    at DestroyableTransform.emit (events.js:169:7)
    at readableAddChunk (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:198:18)
    at DestroyableTransform.Readable.push (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:157:10)
    at DestroyableTransform.Transform.push (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:123:32)
    at afterTransform (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:79:51)
    at TransformState.afterTransform (/var/www/test/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:58:12)

with gulp-sass version 2.2.0 there is no problem.

xzyfer added a commit to xzyfer/gulp-sass that referenced this issue Apr 21, 2016
I believe this was mistakenly removed in dlmanning#353.

@eoneill can you shed some light on why you removed this? It has
caused issues for users.

Fixes dlmanning#469
Fixes dlmanning#473
@xzyfer
Copy link
Collaborator

xzyfer commented Apr 21, 2016

Thanks for report @lughino. I believe I have a fix in #474. Waiting on confirmation from the person who removed this code.

@xzyfer
Copy link
Collaborator

xzyfer commented Apr 21, 2016

A work around for now is setting the includePaths: [] option.

@bigjollygiant14
Copy link

Same issue for me. @extend and @import aren't working anymore. On demo day too :(. Going to try the include paths for now.

@timhettler
Copy link

In previous versions includePaths accepted a String

@xzyfer
Copy link
Collaborator

xzyfer commented Apr 21, 2016

I've released v2.3.1 which restores the old behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants