add the .file property to options before handing off to node-sass

[eoneill]

This sets the file property on the options object that gets passed along to node-sass.

This is important for using eyeglass modules. eyeglass uses a custom importer and without knowing the file path origin, it isn't able to do it's job correctly.

Note that this doesn't really change how node-sass is going to render the file as data still takes precedence over file. This is just preserving the origin of the file.

Related issues:
linkedin/eyeglass#64
linkedin/eyeglass#42

Fixes #324

/cc @chriseppstein

[xzyfer]

👍

[xzyfer]

@eoneill can you please see if it's possible to create a test for this. The reason for this LOC is unclear so it's a prime candidate for being naively removed in the future.

[eoneill]

So I've been trying to come up with a good test case for this, and discovered that we actually already test this functionality by virtue of any other test that does a relative import.

This also led me to discover that we can entirely remove the includePaths augmentation that we do.

The way the current logic works is that we take the path of the current file and add it's parent as the first path in includePaths.

This allows imports to seemingly work correctly, as the relative import fails, but it then finds the file in the parent path automagically added to includePaths.

By simply setting the file property, we can forgo touching includePaths and allow libsass to correctly resolve the paths for us.

I'm not sure what the correct test case is to represent all of this. If you have an idea what we should test, lemme know. I'll keep thinking about it in the meantime and hopefully come up with something.

[gvsboy]

Many thanks for working on this PR! It solves our issue and makes Eyeglass a viable option in the world of Gulp. What is the status?

[eoneill]

Let me know if you would like me to do anything else with this PR. Happy to make any changes/updates or discuss further.

[danreeves]

This would also close #368 and #324

[Keats]

@eoneill re-ran the tests and it's currently failing

[eoneill]

I'll take a look and update my PR if I can fix it.

[eoneill]

Not sure what happened with the rebase, but my last commit (6c133e6) should fix the issues with sourcemaps.

[eoneill]

Resolved rebase issues with --force. Should be good to review now.

[xzyfer]

This seems reasonable to me.

[xzyfer]

I'll happily release this in the new year. I want to deal with any issues that arise whilst I'm on holidays :)

[jefftherobot]

Can this be merged?

[xzyfer]

We're currently in a beta a release so this will appear in the next beta.