New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depends on node-sass #785
Comments
There is a package based on this project with dart-sass replacement https://www.npmjs.com/package/gulp-dart-sass. Try to use it instead of gulp-sass. |
That repo is closing its issue panel. I am fully negative to a 1 contributer forked project without a issue panel. That means if I meet a bug, I must must read though the code and open a PR. And if no responese, I must fork, fix and publish a package of my own, I would rather fork this repo and implement a package by myself. |
Unless the contributer wants to leave this project deperate in the future, I think it's necessary to switch to |
I agree with @Mister-Hope. Please remove the node-sass dependency! |
For anyone wants to use It's a totlly rewritten version of this repo, inlucding:
It's better than
|
Thanks @Mister-Hope I think |
@jerrylow That PR do works, but I still recomand you to use my plugin. This repo is lack of maintainence for quite a long while. I am using typescript for better option hints, and rewrite the test in typescript using jest to provide coverage support, also all the deps are in it's latest version. |
@Mister-Hope actually, good call. |
I think it is useful that this plugin allows for the choice of node-sass or dart-sass, but it is unfortunate that node-sass is used by default and therefore a dependency. Wouldn't an easy fix be to remove the node-sass dependency, remove the assignment to the |
please dont forget that node-sass isnt just "cosmetically" deprecated. https://sass-lang.com/blog/libsass-is-deprecated so node-sass CANNOT stay in this project unless we want to move this repo to the npm graveyard. |
Try my plugin🧐 |
i prefer open source where we keep the quality of a few packages high, over a million duplicated projects, where most of them are broken and you have to be lucky to pick the "right" one. gulp-sass already supports dart-sass. i think just the docs need updating, so the examples propose setting the compiler to |
@kitsunekyo Simple documentation change isn't quite enough - the dependency to node-sass should also be dropped from package.json (which is a breaking change) for this project to remain a viable alternative. The C++ libsass is a horrible transitive dependency to have, even if you don't actually use it at runtime. npm will still try to build it on install and then bursts into flames when some little thing isn't exactly right in the build environment. Just google "node-sass error" and witness the pain. |
Besides the pain to build const sass = require('gulp-sass');
sass.compiler = require('sass'); But I've made the PR #791 to fix this pain, but now I'm thinking of switching to something else :( |
Hello, And remove these "node-sass gulp-sass" packages
And start Gulp, the error was gone. Another option is to edit the line Gulp ran without error too |
@alpwe I guess I wasn't clear enough on what my intention is :) Before node@15 your suggestions would help. |
@duzun Ohh, sory ))) |
@alpwe unfortunately |
Please do this! Needing the newer sass features and unable to have them via |
it is recommended to replace node-sass with dart-sass
The text was updated successfully, but these errors were encountered: