Require node-sass on first access to gulpSass.compiler
#791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use this plugin with `sass`, not `node-sass`, but the line with `require('node-sass')` throws an error, before I have the chance to `gulpSass.compiler = require('sass');`.
The error message says:
`Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 14.x`
This PR should fix the issue transparently.
Closed
|
Thanks all, close this to focus efforts on #802 which is more rounded at this point in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this plugin with
sass, notnode-sass, but the line withrequire('node-sass')throws an error, before I have the chance togulpSass.compiler = require('sass');.The error message says:
Node Sass could not find a binding for your current environment: Linux 64-bit with Node.js 14.xThis PR should fix the issue transparently.
I would also prefer not to include the
node-sasslib as a dependency, maybe a peer-dependency.