Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download functions modified in data.py #144

Merged
merged 13 commits into from
Jul 20, 2021
Merged

download functions modified in data.py #144

merged 13 commits into from
Jul 20, 2021

Conversation

shiwakotisurendra
Copy link
Contributor

closes #106

Copy link
Contributor

@fwfichtner fwfichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the linting works.

If the UnauthorizedError stays there we should have a look at it.

CHANGELOG.rst Outdated Show resolved Hide resolved
ukis_pysat/data.py Outdated Show resolved Hide resolved
ukis_pysat/data.py Show resolved Hide resolved
ukis_pysat/data.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fwfichtner fwfichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, let's keep it open for now though.

Copy link
Contributor

@fwfichtner fwfichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that works, good.

ukis_pysat/data.py Outdated Show resolved Hide resolved
@fwfichtner
Copy link
Contributor

You can also remove pylandsat from all requirements here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #144 (4d8e194) into master (9154ddb) will decrease coverage by 4.31%.
The diff coverage is 33.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   81.31%   76.99%   -4.32%     
==========================================
  Files          11       11              
  Lines         915     1004      +89     
==========================================
+ Hits          744      773      +29     
- Misses        171      231      +60     
Flag Coverage Δ
unittests 76.99% <33.69%> (-4.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ukis_pysat/data.py 49.22% <22.66%> (-10.56%) ⬇️
ukis_pysat/members.py 89.28% <80.00%> (-10.72%) ⬇️
tests/test_data.py 90.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9154ddb...4d8e194. Read the comment docs.

@fwfichtner
Copy link
Contributor

@MWieland what do you think?
@shiwakotisurendra please add sources according to the license to the code you basically copied.

@MWieland
Copy link
Collaborator

Looks good to me. Much better then before. Agree with @fwfichtner to add sources of possibly copied code snippets.

ukis_pysat/files.json Outdated Show resolved Hide resolved
Copy link
Contributor

@fwfichtner fwfichtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiwakotisurendra please check the line-endings of tests/test_data.py, I guess you did not change every file.

@fwfichtner fwfichtner merged commit d734c70 into master Jul 20, 2021
@fwfichtner fwfichtner deleted the download-modify branch July 20, 2021 11:53
@fwfichtner fwfichtner mentioned this pull request Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace EarthExplorer with SAT API
4 participants