-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download functions modified in data.py #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the linting works.
If the UnauthorizedError
stays there we should have a look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, let's keep it open for now though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that works, good.
You can also remove |
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
- Coverage 81.31% 76.99% -4.32%
==========================================
Files 11 11
Lines 915 1004 +89
==========================================
+ Hits 744 773 +29
- Misses 171 231 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@MWieland what do you think? |
Looks good to me. Much better then before. Agree with @fwfichtner to add sources of possibly copied code snippets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shiwakotisurendra please check the line-endings of tests/test_data.py, I guess you did not change every file.
closes #106