Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated GitHub action #345

Merged
merged 8 commits into from
May 28, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented May 20, 2023

Resolves: #269

Update workflow files to use:

  • uses: actions/setup-python@v4
  • uses: actions/cache@v3

@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 3b4d73e
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/64686bbfe3f4c100085f5a5b

@tungbq tungbq marked this pull request as ready for review May 20, 2023 06:31
@tungbq
Copy link
Contributor Author

tungbq commented May 20, 2023

There is no change in the test suites or the code, not sure why some CI checkers are failing with DB error:

Database Error
  connection to server at "dlttests.cwz0jfxu0m7m.eu-central-1.rds.amazonaws.com" (18.196.0.3), port 5432 failed: fe_sendauth: no password supplied
  
Error:   file_log:eventmgr.py:63 06:43:43.[120](https://github.com/dlt-hub/dlt/actions/runs/5030898708/jobs/9023625301?pr=345#step:7:121)150 [error] [MainThread]: Encountered an error:

@rudolfix
Copy link
Collaborator

@tungbq thanks for fixing this. the reason is that PRs from fork do not have access to our repo secrets so destination tests will not run. I'll take a look and probably merge your work and test it again. we need to split the duckdb and postgres tests from other destinations so those can work from forks

@rudolfix rudolfix merged commit a101886 into dlt-hub:devel May 28, 2023
@tungbq tungbq deleted the update-deprecated-github-action branch May 31, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated GitHub Actions
2 participants