Features/dlt deploy airflow #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
requested changes
May 25, 2023
…ated GithubAction and Airflow deployment classes
rudolfix
approved these changes
May 29, 2023
There was a problem hiding this comment.
looks good and ready to merge. parametrize the existing test was cool. I did following changes:
- renamed to airflow-composer: we require github repo and distribute cloudbuild. if we need vanilla airflow we can add that
- any modifications should be made only after instructions are displayed: so there's another method in the base class (
_make_modifications) being called at the end - you removed the code that displays actual env variables, I added those back...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.