-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/dlt deploy airflow #356
Conversation
✅ Deploy Preview for dlt-hub-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! most of my comments are to write proper object oriented code (because you already defined class for the deployment and general direction is good)
…ated GithubAction and Airflow deployment classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good and ready to merge. parametrize the existing test was cool. I did following changes:
- renamed to airflow-composer: we require github repo and distribute cloudbuild. if we need vanilla airflow we can add that
- any modifications should be made only after instructions are displayed: so there's another method in the base class (
_make_modifications
) being called at the end - you removed the code that displays actual env variables, I added those back...
No description provided.