Fix/requests error handling #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
steinitzu
commented
Jul 7, 2023
rudolfix
requested changes
Jul 7, 2023
There was a problem hiding this comment.
looks excellent! +1 for removing the tuples. pls. see one proposed improvement in the review.
what is missing is a short explanation how the timeout and retries are configured. please add a new section to performance.md in the docs - give an example how to configure retries and what are the defaults
| @@ -146,27 +148,29 @@ class Client: | |||
| """ | |||
| def __init__( | |||
There was a problem hiding this comment.
we should be able to decorate this @with_config(RuntimeConfiguration). and the right arguments will be injected. why I think it is cool:
- if someone creates a session from a source, the configuration may be defined in the scope of the source ("sources", "pipedrive", "runtime")
- maybe if at some point we'll do a lazy instantiation of default client, even the default config will be scoped
There was a problem hiding this comment.
Makes sense. Added this and some docs!
steinitzu
force-pushed
the
fix/requests-error-handling
branch
from
d0978ca
to
60b4a46
Compare
steinitzu
force-pushed
the
fix/requests-error-handling
branch
from
60b4a46
to
cf0734f
Compare
rudolfix
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #473
ChunkedLoadingExceptionadded to retry list. Seems this almost always due to some kind of dropped connectionTimeoutandConnectionErrorare already retried and all server errors inherit thoseRunConfiguration