chore: update gh-go to v2 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #243 by updating go-gh from v0.1.0 to v2.0.0 (the latest release) as well as future proofs against breaking changes given that they are unlikely to make more breaking changes for a while.
How did you test this change?
My config currently has no token as it's stored securely so it was unable to connect with the released version of gh-dash, so after making this change I validated that I was able to use gh-dash to query my open issues/prs as shown in the recordings below.
Images/Videos
With secure token before updating the go-gh library
Screen.Recording.2023-04-30.at.2.51.29.PM.mov
With secure token update go-gh library
Screen.Recording.2023-04-30.at.2.53.09.PM.mov