Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for configuing a default local repository path #327

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

markfeinstein
Copy link
Contributor

Summary

Add fallback logic to the GetRepoLocalPath to allow a default_path to be configured to handle repository paths that aren't explicitly configured.

Additional changes:

  • Update deps
  • Add testify module
  • Refactor repo path unit test to use table tests

How did you test this change?

  • Ran unit tests
  • Local testing with a repo that doeos not have a matching or wildcard definition in gh-dash
    • Perform a checkout of a pr
    • Open a pr in Octo.nvim

@dlvhdr
Copy link
Owner

dlvhdr commented Jan 30, 2024

Thank you! I'll take a look later this week

Copy link
Owner

@dlvhdr dlvhdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants