Remove default_path support in repoPaths configuration
#345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we support the more general `:owner/:repo` template configuration (85a75fe), the prior `default_path` functionality (d9ef14a) is redundant - e.g. this configuration: ``` default_path: ~/code/repos ``` can be achieved equivalently with: ``` :owner/:repo: ~/code/repos/:repo ``` Thus, we are removing the `default_path` syntax.
dlvhdr
reviewed
Mar 7, 2024
dlvhdr
approved these changes
Mar 7, 2024
|
Heads up @markfeinstein @ushmz @Arinono since you are/were using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we support the more general
:owner/:repotemplate configuration (#343), the priordefault_pathfunctionality (#327) is redundant - e.g. this configuration:can be achieved equivalently with:
Thus, we are removing the
default_pathsyntax.How did you test this change?
I updated the automated tests to show how the
default_pathtest case is covered with the:owner/:reposyntax.