Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gemfile.d for upstream CI #116

Merged
merged 1 commit into from
May 6, 2024

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Apr 9, 2024

The gemspec shouldn't contain environment variables, because it's also used in other contexts where it could break.

In common CI we read gemfile.d/*.rb so this is the best place for bundler overrides.

Fixes: 3eedb81 ("feat(actions): switch to upstream CI templates (#113)")

I'm not 100% sure this works, but if it does then I'll document it as a recommended approach.

@laugmanuel
Copy link
Member

This approach looks simpler/cleaner - let's see what the pipeline says.

The gemspec shouldn't contain environment variables, because it's also
used in other contexts where it could break.

In common CI we read gemfile.d/*.rb so this is the best place for
bundler overrides.

Fixes: 3eedb81 ("feat(actions): switch to upstream CI templates (dm-drogeriemarkt#113)")
@ekohl
Copy link
Contributor Author

ekohl commented Apr 10, 2024

I failed rubocop. Now updated

@laugmanuel
Copy link
Member

Now failing due to theforeman/foreman-js#477 / theforeman/foreman#10116.
Will this patches be backported to Foreman 3.7 / 3.8 / 3.9?

@ekohl
Copy link
Contributor Author

ekohl commented Apr 10, 2024

Will this patches be backported to Foreman 3.7 / 3.8 / 3.9?

We literally just now discussed it for 3.9, but 3.7 & 3.8 are EOL and I don't think we'll update those anymore. There certainly won't be any more releases.

@ekohl
Copy link
Contributor Author

ekohl commented Apr 10, 2024

@laugmanuel since current master will also fail on the same thing, should this be merged?

@laugmanuel
Copy link
Member

Will this patches be backported to Foreman 3.7 / 3.8 / 3.9?

We literally just now discussed it for 3.9, but 3.7 & 3.8 are EOL and I don't think we'll update those anymore. There certainly won't be any more releases.

I guess we need to drop tests for that Foreman version then. I'll prepare a PR for that.
What's the plan for 3.9 and newer?

@laugmanuel since current master will also fail on the same thing, should this be merged?

Let's wait until old versions are dropped from CI.

@ekohl
Copy link
Contributor Author

ekohl commented Apr 11, 2024

What's the plan for 3.9 and newer?

Do cherry picks of theforeman/foreman@7008091, which is being worked on.

@laugmanuel laugmanuel merged commit 2e1ff55 into dm-drogeriemarkt:master May 6, 2024
27 of 33 checks passed
@laugmanuel
Copy link
Member

Thanks @ekohl

@ekohl ekohl deleted the use-gemfile.d branch May 6, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants