Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the parse and createCurrencyFormat function #26

Closed
wants to merge 1 commit into from

Conversation

johnny-dash
Copy link

In our situation, we don't want to register the plugin globally as most of the pages are not using it. Therefore we go with directive solution which allows you to import this currency input on demand. However, this means we need to implement our own parseCurrency method and we can't config the default currency and locale (The default locale configuration is passed in as a parameter when the library is registered globally). When we creating our own parseCurrency function, we find that parse and createCurrencyFormat in the parseCurrency implementation is not exported. This pull request is to export these two functions so we can create our own parseCurrency function

@johnny-dash
Copy link
Author

johnny-dash commented Aug 29, 2019

The pull request here is to fix the issue: #27

@dm4t2
Copy link
Owner

dm4t2 commented Sep 1, 2019

Hi, thanks for contributing, but the functions parse and createCurrencyFormat are not intended to be part of the public API. I will provide a appropriate solution to allow parsing without global Vue plugin installation.

@dm4t2 dm4t2 closed this Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants