Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for angular 5 - replace ngOutletContext with ngTemplateOutletContext #51

Closed
jaa1982 opened this issue Nov 2, 2017 · 1 comment

Comments

@jaa1982
Copy link

jaa1982 commented Nov 2, 2017

https://github.com/dmacfarlane/angular2-mentions/blob/b13b77bab4a7ac4edc10cf93c23b47c8e77f1b49/src/mention/mention-list.component.ts#L40

Angular v5 removes support for NgTemplateOutlet#ngOutletContext in favor of ngTemplateOutletContext , which now results in a compile time error if included. Per docs, this has actually been deprecated since Angular 4, but did not result in a compile time error

angular/angular@7522987

It looks like there is just one reference to ngOutletContext on the above line. If this could be replaced with ngTemplateOutletContext , we could support both Angular 4 & 5

dmacfarlane added a commit that referenced this issue Nov 7, 2017
@dmacfarlane
Copy link
Owner

Version 0.7.2 published to fix this. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants