Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pure Go terraform-provider-libvirt experiment #813

Closed
wants to merge 83 commits into from
Closed

Pure Go terraform-provider-libvirt experiment #813

wants to merge 83 commits into from

Commits on Nov 12, 2020

  1. Rename libvirt to libvirtc

    @dmacvicar
    dmacvicar committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    cf1dd9a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. port

    @dmacvicar
    dmacvicar committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    b552ae5 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. port

    @dmacvicar
    dmacvicar committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    8d6c882 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. port

    @dmacvicar
    dmacvicar committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    dd17534 View commit details
    Browse the repository at this point in the history

  2. port

    @dmacvicar
    dmacvicar committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    4d5f125 View commit details
    Browse the repository at this point in the history

  3. port

    @dmacvicar
    dmacvicar committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    e55600a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. port

    @dmacvicar
    dmacvicar committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    5620a5e View commit details
    Browse the repository at this point in the history

  2. remove

    @dmacvicar
    dmacvicar committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    fe20b3d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. port

    @dmacvicar
    dmacvicar committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    1873a74 View commit details
    Browse the repository at this point in the history

  2. test push rights to pr branch

    @karlskewes
    karlskewes committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    a63b9c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. remove test file used to validate push rights

    @karlskewes
    karlskewes committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    2befcb3 View commit details
    Browse the repository at this point in the history

  2. port - wait for network active

    @karlskewes
    karlskewes committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    37ea9e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. port - partial volume create

    @karlskewes
    karlskewes committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    ddc57db View commit details
    Browse the repository at this point in the history

  2. port - remove subpackages disk & volume 

    These can be moved into the `main` package later if we progress the idea
    @karlskewes
    karlskewes committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    ecacc6b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. port - volume copier

    @karlskewes
    karlskewes committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    7a73944 View commit details
    Browse the repository at this point in the history

  2. port - volume copier - missing close, just defer it

    @karlskewes
    karlskewes committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    e97e55f View commit details
    Browse the repository at this point in the history

  3. port - volume copier - remove var decl

    @karlskewes
    karlskewes committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    b710bc2 View commit details
    Browse the repository at this point in the history

  4. port - partial cloudinit

    @karlskewes
    karlskewes committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    cc436e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. port - more volume copying

    @karlskewes
    karlskewes committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    7732822 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. port - volumes

    @karlskewes
    karlskewes committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    fa27318 View commit details
    Browse the repository at this point in the history

  2. port - network def partial

    @karlskewes
    karlskewes committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    f669488 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. Merge branch 'master' of github.com:dmacvicar/terraform-provider-libv… 

    …irt into pure-go
    @MalloZup
    MalloZup committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    9f59d67 View commit details
    Browse the repository at this point in the history

  2. port - pool partial

    @karlskewes
    karlskewes committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    f4fc730 View commit details
    Browse the repository at this point in the history

  3. port - start network tests

    @karlskewes
    karlskewes committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    79d9a7f View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. port - tests bulk pass - compiles but fails tests

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    507d921 View commit details
    Browse the repository at this point in the history

  2. port - missed some

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    b52b7b3 View commit details
    Browse the repository at this point in the history

  3. port - volume.go

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    dd7470a View commit details
    Browse the repository at this point in the history

  4. port - restore error var & use struct field directly

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    cd73a92 View commit details
    Browse the repository at this point in the history

  5. port - use struct field directly

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    1c97ccf View commit details
    Browse the repository at this point in the history

  6. port - network tests require accept testing enabled

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    6765124 View commit details
    Browse the repository at this point in the history

  7. port - default network test requires network exists

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f7893fc View commit details
    Browse the repository at this point in the history

  8. port - use previous libvirt connect behaviour for tests (blind URI)

    @karlskewes
    karlskewes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    2b2ae01 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Merge branch 'pure-go' of github.com:dmacvicar/terraform-provider-lib… 

    …virt into pure-go
    @MalloZup
    MalloZup committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    673c671 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2021

  1. port - record/capture io close error

    @karlskewes
    karlskewes committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    592b03b View commit details
    Browse the repository at this point in the history

  2. port - close our new second connection too

    @karlskewes
    karlskewes committed Jan 3, 2021
    Configuration menu
    Copy the full SHA
    08641cd View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. port - pipe in goroutine so can close - TBC pipe required

    @karlskewes
    karlskewes committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    ca153e4 View commit details
    Browse the repository at this point in the history

  2. port - download via buffer - review/revise 

    this may not be suitable for large files...
    @karlskewes
    karlskewes committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6001aed View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Merge branch 'pure-go' of github.com:dmacvicar/terraform-provider-lib… 

    …virt into pure-go
    @MalloZup
    MalloZup committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    3b78009 View commit details
    Browse the repository at this point in the history

  2. Fix helper

    @MalloZup
    MalloZup committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    c8e14c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Use new exported error from digital ocean library

    @MalloZup
    MalloZup committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    02a9482 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. port - reinstate error checks with new upstream error code

    @karlskewes
    karlskewes committed May 20, 2021
    Configuration menu
    Copy the full SHA
    51dfb96 View commit details
    Browse the repository at this point in the history

  2. port - missed removing old if

    @karlskewes
    karlskewes committed May 20, 2021
    Configuration menu
    Copy the full SHA
    c549f79 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. port - fix domain acceptance tests - uuid handling

    @karlskewes
    karlskewes committed May 21, 2021
    Configuration menu
    Copy the full SHA
    26360cc View commit details
    Browse the repository at this point in the history

  2. port - missed removing old if now test back

    @karlskewes
    karlskewes committed May 21, 2021
    Configuration menu
    Copy the full SHA
    7a75979 View commit details
    Browse the repository at this point in the history

  3. port - fix most network acceptance tests - active handling

    @karlskewes
    karlskewes committed May 21, 2021
    Configuration menu
    Copy the full SHA
    5f56ff6 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. port - fix network lookup uuid usage

    @karlskewes
    karlskewes committed May 27, 2021
    Configuration menu
    Copy the full SHA
    8b19625 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. port - NetworkUpdate params are now swapped 

    At some point we will need to swap the params back once a change has
made it's way through the system.

digitalocean/go-libvirt#87

`command` and `section` params are reversed now and will need to be put back in order when fix flows through
history: https://listman.redhat.com/archives/libvir-list/2021-March/msg00054.html
merged fix: https://listman.redhat.com/archives/libvir-list/2021-March/msg00758.html
    @karlskewes
    karlskewes committed May 28, 2021
    Configuration menu
    Copy the full SHA
    bec3fcd View commit details
    Browse the repository at this point in the history

  2. port - fix template test - missing nvram undefine flag

    @karlskewes
    karlskewes committed May 28, 2021
    Configuration menu
    Copy the full SHA
    bcb5520 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2021

  1. port - some missing libvirtc uses

    @karlskewes
    karlskewes committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    e830316 View commit details
    Browse the repository at this point in the history

  2. Fix tests crashing due to client setup 

    Retrieve the client from testAccProvider, like all other tests
    @dmacvicar
    dmacvicar committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    870e532 View commit details
    Browse the repository at this point in the history

  3. port - update mock parameters to upstream type

    @karlskewes
    karlskewes committed Jun 6, 2021
    Configuration menu
    Copy the full SHA
    b59a407 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. No need to return terraform.ResourceProvider

    @dmacvicar
    dmacvicar committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    d922fb7 View commit details
    Browse the repository at this point in the history

  2. Basic support for libvirt URIs

    @dmacvicar
    dmacvicar committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    90a9f82 View commit details
    Browse the repository at this point in the history

  3. Remove acceptance tests not using the resource test framework. 

    Without using the resources, the test provider has no life-cycle and depends
on resource acceptance tests to have run first and initialize the provider.

These tests are covered by the resource Read method, so they are redundant.
    @dmacvicar
    dmacvicar committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    b4e8ec6 View commit details
    Browse the repository at this point in the history

  4. Revert "No need to return terraform.ResourceProvider" 

    This reverts commit de0cd021dc68ebea62edb32296ac18bf429d1274.
    @dmacvicar
    dmacvicar committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    1a28169 View commit details
    Browse the repository at this point in the history

  5. Remove libvirt bindings

    @dmacvicar
    dmacvicar committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9199cf6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Support for libvirt connection URIs 

    Including implementation for ssh, tcp, tls and unix.
    @dmacvicar
    dmacvicar committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    1a86985 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Add github workflow 

    No acceptance tests for now, as Github hosted runner do not support nested virtualization.
    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    bfe1699 View commit details
    Browse the repository at this point in the history

  2. Install xsltproc before running testsuite 

    Testsuite requires xsltproc for the xml transformation feature.
    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    68dd458 View commit details
    Browse the repository at this point in the history

  3. Build on all platforms

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    75f0215 View commit details
    Browse the repository at this point in the history

  4. Setup terraform before terraform fmt

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    829fbf5 View commit details
    Browse the repository at this point in the history

  5. Setup xsltproc for different OS

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    7a2f260 View commit details
    Browse the repository at this point in the history

  6. Improve skipping acceptance tests

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    ad4bda3 View commit details
    Browse the repository at this point in the history

  7. Fix URL handling on Windows

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d59e6b6 View commit details
    Browse the repository at this point in the history

  8. Fix temporary directory on Windows

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    e9348a2 View commit details
    Browse the repository at this point in the history

  9. Fix URL handling on Windows

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1642492 View commit details
    Browse the repository at this point in the history

  10. Remove unused import

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    617b48c View commit details
    Browse the repository at this point in the history

  11. Simplify test file server with httptest

    @dmacvicar
    dmacvicar committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    31a1b6e View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2021

  1. Fix tests on Windows

    @dmacvicar
    dmacvicar committed Jun 26, 2021
    Configuration menu
    Copy the full SHA
    0806c34 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. Make sure we build a valid OS path

    @dmacvicar
    dmacvicar committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    171c384 View commit details
    Browse the repository at this point in the history

  2. Fix Windows tests by using simple paths

    @dmacvicar
    dmacvicar committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    cf78708 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Fix image URL handling on Windows

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    07facfd View commit details
    Browse the repository at this point in the history

  2. go vet

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6252344 View commit details
    Browse the repository at this point in the history

  3. Include Windows artifact

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    7acb4f6 View commit details
    Browse the repository at this point in the history

  4. Windows is slower than I thought

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    df5d176 View commit details
    Browse the repository at this point in the history

  5. Start server so that URI is not empty

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    fccf009 View commit details
    Browse the repository at this point in the history

  6. Use t.TempDir()

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    992883f View commit details
    Browse the repository at this point in the history

  7. Revert creating tmp file in private tmp dir

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    d9b7d22 View commit details
    Browse the repository at this point in the history

  8. Check for chmod error

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    8ca6e00 View commit details
    Browse the repository at this point in the history

  9. Workaround for bug in NetworkUpdate reversed parameters 

    See:
https://listman.redhat.com/archives/libvir-list/2021-March/msg00054.html
https://listman.redhat.com/archives/libvir-list/2021-March/msg00760.html

https://gitlab.com/libvirt/libvirt/-/commit/b0f78d626a18bcecae3a4d165540ab88bfbfc9ee

Supersedes bec3fcd
    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    22df5a2 View commit details
    Browse the repository at this point in the history

  10. Add releaser in order to publish to registry

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    274df11 View commit details
    Browse the repository at this point in the history

  11. Add goreleaser in order to publish to registry

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    f4e6208 View commit details
    Browse the repository at this point in the history

  12. Update README

    @dmacvicar
    dmacvicar committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5537d35 View commit details
    Browse the repository at this point in the history