Pure Go terraform-provider-libvirt experiment

.github/workflows/release.yml

@@ -0,0 +1,49 @@
+# This GitHub action can publish assets for release when a tag is created.
+# Currently its setup to run on any tag that matches the pattern "v*" (ie. v0.1.0).
+#
+# This uses an action (hashicorp/ghaction-import-gpg) that assumes you set your
+# private key in the `GPG_PRIVATE_KEY` secret and passphrase in the `PASSPHRASE`
+# secret. If you would rather own your own GPG handling, please fork this action
+# or use an alternative one for key handling.
+#
+# You will need to pass the `--batch` flag to `gpg` in your signing step
+# in `goreleaser` to indicate this is being used in a non-interactive mode.
+#
+name: release
+on:
+  push:
+    tags:
+      - 'v*'
+jobs:
+  goreleaser:
+    runs-on: ubuntu-latest
+    steps:
+      -
+        name: Checkout
+        uses: actions/checkout@v2.3.4
+      -
+        name: Unshallow
+        run: git fetch --prune --unshallow
+      -
+        name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: 1.14
+      -
+        name: Import GPG key
+        id: import_gpg
+        uses: hashicorp/ghaction-import-gpg@v2.1.0
+        env:
+          # These secrets will need to be configured for the repository:
+          GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
+          PASSPHRASE: ${{ secrets.PASSPHRASE }}
+      -
+        name: Run GoReleaser
+        uses: goreleaser/goreleaser-action@v2.5.0
+        with:
+          version: latest
+          args: release --rm-dist
+        env:
+          GPG_FINGERPRINT: ${{ steps.import_gpg.outputs.fingerprint }}
+          # GitHub sets this automatically
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/test.yml

@@ -0,0 +1,55 @@
+name: Tests
+on:
+  pull_request:
+    paths-ignore:
+      - '*.md'
+      - 'website/*'
+  push:
+    branches:
+      - main
+    paths-ignore:
+      - '*.md'
+      - 'website/*'
+jobs:
+  build:
+    name: Build
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        include:
+          - {os: ubuntu-latest, go: 1.16}
+          - {os: windows-latest, go: 1.16}
+          - {os: macos-latest, go: 1.16}
+    timeout-minutes: 10
+    steps:
+      - name: Set up Go
+        uses: actions/setup-go@v2
+        with:
+          go-version: ${{ matrix.go }}
+        id: go
+      - name: Check out code into the Go module directory
+        uses: actions/checkout@v2
+      - name: Setup terraform
+        uses: hashicorp/setup-terraform@v1
+      - name: Terraform fmt
+        run: |
+          make tf-check
+      - name: Build
+        run: |
+          make
+      - name: Test pre-requisites (Linux)
+        run: sudo apt-get -y install xsltproc
+        if: runner.os == 'Linux'
+      - name: Test pre-requisites (MacOS)
+        run: brew install libxslt
+        if: runner.os == 'MacOS'
+      - name: Test pre-requisites (Windows)
+        run: choco install xsltproc
+        if: runner.os == 'Windows'
+      - name: Test
+        run: |
+          make test
+      - uses: actions/upload-artifact@v2
+        with:
+          name: terraform-provider-libvirt-${{ matrix.os }}
+          path: ${{ github.workspace }}/terraform-provider-libvirt*

.goreleaser.yml

@@ -0,0 +1,54 @@
+# Visit https://goreleaser.com for documentation on how to customize this
+# behavior.
+before:
+  hooks:
+    # this is just an example and not a requirement for provider building/publishing
+    - go mod tidy
+builds:
+- env:
+    # goreleaser does not work with CGO, it could also complicate
+    # usage by users in CI/CD systems like Terraform Cloud where
+    # they are unable to install libraries.
+    - CGO_ENABLED=0
+  mod_timestamp: '{{ .CommitTimestamp }}'
+  flags:
+    - -trimpath
+  ldflags:
+    - '-s -w -X main.version={{.Version}} -X main.commit={{.Commit}}'
+  goos:
+    - freebsd
+    - windows
+    - linux
+    - darwin
+  goarch:
+    - amd64
+    - '386'
+    - arm
+    - arm64
+  ignore:
+    - goos: darwin
+      goarch: '386'
+  binary: '{{ .ProjectName }}_v{{ .Version }}'
+archives:
+- format: zip
+  name_template: '{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}'
+checksum:
+  name_template: '{{ .ProjectName }}_{{ .Version }}_SHA256SUMS'
+  algorithm: sha256
+signs:
+  - artifacts: checksum
+    args:
+      # if you are using this in a GitHub action or some other automated pipeline, you
+      # need to pass the batch flag to indicate its not interactive.
+      - "--batch"
+      - "--local-user"
+      - "{{ .Env.GPG_FINGERPRINT }}" # set this environment variable for your signing key
+      - "--output"
+      - "${signature}"
+      - "--detach-sign"
+      - "${artifact}"
+release:
+  # If you want to manually examine the release before its live, uncomment this line:
+  # draft: true
+changelog:
+  skip: true

README.md

@@ -43,39 +43,18 @@ What is *NOT* in scope:
 * To support every advanced feature [libvirt](https://libvirt.org/) supports
 
   This would make the mapping from terraform complicated and not maintanable. See the [How to contribute](CONTRIBUTING.md) section to understand how to approach new features.
-
-## Downloading
-
-Builds for openSUSE, CentOS, Ubuntu, Fedora are created with openSUSE's [OBS](https://build.opensuse.org). The build definitions are available for both the [stable](https://build.opensuse.org/package/show/systemsmanagement:terraform/terraform-provider-libvirt) and [master](https://build.opensuse.org/package/show/systemsmanagement:terraform:unstable/terraform-provider-libvirt) branches.
-
-## Using published binaries/builds
-
-* *Stable releases*: Head to the [releases section](https://github.com/dmacvicar/terraform-provider-libvirt/releases) and download the latest stable release build for your distribution.
-* *git master builds*: Head to the [download area of the OBS project](https://download.opensuse.org/repositories/systemsmanagement:/terraform:/unstable/) and download the build for your distribution.
 
-## Using packages
+## Getting the libvirt provider
 
-Follow the instructions for your distribution:
+The provide is available via the [Terraform Registry](https://registry.terraform.io/providers/dmacvicar/libvirt/latest).
 
-* [Packages for stable releases](https://software.opensuse.org/download/package?project=systemsmanagement:terraform&package=terraform-provider-libvirt)
-* [Packages for current git master](https://software.opensuse.org/download/package?project=systemsmanagement:terraform:unstable&package=terraform-provider-libvirt)
+You can also manually download it from the [releases section](https://github.com/dmacvicar/terraform-provider-libvirt/releases) on Github
 
 ## Building from source
 
 ### Requirements
 
--	[Terraform](https://www.terraform.io/downloads.html)
--	[Go](https://golang.org/doc/install) (to build the provider plugin)
--	[libvirt](https://libvirt.org/downloads.html) 1.2.14 or newer development headers
--	`cgo` is required by the [libvirt-go](https://github.com/libvirt/libvirt-go) package. `export CGO_ENABLED="1"`
-
-
-This project uses [go modules](https://github.com/golang/go/wiki/Modules) to declare its dependencies.
-
-Ensure you have the latest version of Go installed on your system, terraform usually
-takes advantage of features available only inside of the latest stable release.
-
-You need also need libvirt-dev(el) package installed.
+-	[Go](https://golang.org/doc/install) is required for building.
 
 ### Building The Provider
 
@@ -86,28 +65,12 @@ make
 
 The binary will be called `terraform-provider-libvirt`.
 
-#### Windows
-
-To build it on Windows (64bit) one can use MinGW64 (http://www.msys2.org/)
-
-Install Golang on Windows  
-Clone terraform-provider-libvirt repository  
-Open MinGW64 Console
-```console
-pacman -S mingw-w64-x86_64-libvirt
-export PATH=$PATH:/c/Go/bin
-pacman -S mingw-w64-x86_64-pkg-config
-pacman -S mingw-w64-x86_64-glib2
-pacman -S mingw-w64-x86_64-dbus-glib
-pacman -S mingw-w64-x86_64-libssh
-pacman -S mingw-w64-x86_64-yajl
-go install
-```
-
 # Installing
 
 *  Check that libvirt daemon 1.2.14 or newer is running on the hypervisor (`virsh version --daemon`)
+*  [Terraform](https://www.terraform.io/downloads.html)
 * `mkisofs` is required to use the [CloudInit](website/docs/r/cloudinit.html.markdown)
+* `xsltproc` is required to transform generated libvirt XML
 
 [Copied from the Terraform documentation](https://www.terraform.io/docs/configuration/providers.html#third-party-plugins):
 
@@ -197,7 +160,7 @@ Be aware that this variables may be subject to change again in future versions.
 
 ## Authors
 
-* Duncan Mac-Vicar P. <dmacvicar@suse.de>
+* Duncan Mac-Vicar P. <duncan@mac-vicar.eu>
 
 See also the list of [contributors](https://github.com/dmacvicar/terraform-provider-libvirt/graphs/contributors) who participated in this project.
 

go.mod

@@ -2,18 +2,23 @@ module github.com/dmacvicar/terraform-provider-libvirt
 
 require (
 	github.com/c4milo/gotoolkit v0.0.0-20170704181456-e37eeabad07e // indirect
+	github.com/coreos/go-semver v0.3.0 // indirect
 	github.com/davecgh/go-spew v1.1.1
+	github.com/digitalocean/go-libvirt v0.0.0-20210524223541-696696fc24e0
+	github.com/fatih/color v1.10.0 // indirect
 	github.com/google/uuid v1.1.2
-	github.com/hashicorp/terraform-plugin-sdk v1.4.0
+	github.com/hashicorp/terraform-plugin-sdk v1.9.0
 	github.com/hooklift/assert v0.0.0-20170704181755-9d1defd6d214 // indirect
 	github.com/hooklift/iso9660 v1.0.0
-	github.com/libvirt/libvirt-go v5.10.0+incompatible
 	github.com/libvirt/libvirt-go-xml v5.10.0+incompatible
 	github.com/mattn/goveralls v0.0.2
 	github.com/pborman/uuid v1.2.0 // indirect
-	github.com/stretchr/testify v1.5.1
+	github.com/stretchr/testify v1.7.0
 	github.com/terraform-providers/terraform-provider-ignition v1.2.1
-	golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f
+	golang.org/x/crypto v0.0.0-20191202143827-86a70503ff7e
+	golang.org/x/lint v0.0.0-20200302205851-738671d3881b
+	golang.org/x/sys v0.0.0-20210514084401-e8d321eab015 // indirect
+	gopkg.in/yaml.v2 v2.4.0 // indirect
 )
 
 replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999