Fix crashes caused by CREATE INDEX SQL commands upon DB update by add… #515
Conversation
| } | ||
| buffer.append("INDEX "); | ||
| buffer.append("INDEX IF NOT EXISTS"); |
There was a problem hiding this comment.
How can this work? This doesn't leave a space between "EXISTS" and the table name.
There was a problem hiding this comment.
Sorry, the commited version missed the space, the 'IF NOT EXIST ' append was in a separate line when I tested.
This is why the build failed as well. Fixed now.
| buffer.append("INDEX "); | ||
| buffer.append(table).append("_").append(fields[0]).append("_idx ON "); | ||
| buffer.append("INDEX IF NOT EXISTS "); | ||
| buffer.append(table).append("_").append(fields[0]).append("_idx ON "); |
There was a problem hiding this comment.
I've squashed-rebased now to fix this, please check again.
But finally it turned out what these look like identation changes are: the file has tabs instead of spaces and the IDE keeps them even though the code style uses spaces.
There is this settings:
And this notification:
(So in my commit those 2 lines were reformatted for some reason.)
I guess we could fix this in a separate ticket. Turn off that settings and re-format alll project files, to remove the tabs.
…ing IF NOT EXISTS clause. #382
lemonboston
force-pushed
the
bugs/382-db-update
branch
from
b32aa16
to
bfa59d1
Compare
…ing IF NOT EXISTS clause. #382
Steps to reproduce the crash:
TaskDatabaseHelper#DATABASE_VERSION = 15(may also need
allowBackup=falsein manifest)TaskDatabaseHelper#DATABASE_VERSION = 16Doing the same with this branch should not result in a crash.