Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Allow loading a template from a public URL #3

Closed
6 of 7 tasks
dmgress opened this issue Nov 25, 2015 · 3 comments
Closed
6 of 7 tasks

Allow loading a template from a public URL #3

dmgress opened this issue Nov 25, 2015 · 3 comments
Assignees
@dmgress
Labels
enhancement

Comments

@dmgress
Copy link
Owner

dmgress commented Nov 25, 2015

Given an URL the application should load the document and visualize the template if it's a valid CloudFormation template.

  • Able to load and render an example template from AWS
  • Able to load a faulty template (the editor shows the template with an error, no graph update)
  • Shows URL on successful template loading
  • Notify when the URL is not a valid template
  • Won't bother trying an invalid URL
  • A 40x or 50x status code is shown as notification
  • Notifies when redirecting
@dmgress dmgress self-assigned this Nov 25, 2015
@dmgress dmgress mentioned this issue Nov 25, 2015
Closed
@dmgress
Copy link
Owner Author

dmgress commented Nov 25, 2015

Loading random URLs through AJAX is not possible because CORS causes failures in the request.

dmgress added a commit that referenced this issue Nov 25, 2015
@dmgress
First solution to loading AWS example template
f50c9e9 
First checkbox of #3.

Clicking the globe will open an input field. Pressing the enter key
or the glove will fire a request with the current value.

There's no validity check yet. Request goes through 3rd party proxy
 which is not really what I wanted.
@dmgress dmgress mentioned this issue Nov 25, 2015
Open
5 tasks
dmgress added a commit that referenced this issue Nov 26, 2015
@dmgress
Keep input visible when the value is not a valid url
709e5f6 
Use standard HTML5 validation to verify the field is a valid URL
 before trying any requests. another tick for #3
@dmgress
Copy link
Owner Author

dmgress commented Nov 26, 2015

https://s3-ap-southeast-1.amazonaws.com/cloudformation-templates-ap-southeast-1/WordPress_Multi_AZ.template is a good example resource to load

@dmgress
Copy link
Owner Author

dmgress commented Nov 27, 2015

When I tried adding notifications I noticed it still tries empty URLs

dmgress added a commit that referenced this issue Nov 27, 2015
@dmgress
Ticks off more boxes of #3 for loading and notifications
0bf84ec 
* Show URL for successful load
* Show 40x and 50x errors as notifications
* Notifies when the URL is not a valid template
* Loads the faulty template into the editor
@dmgress dmgress mentioned this issue Nov 27, 2015
Merged
dmgress added a commit that referenced this issue Nov 27, 2015
@dmgress
Merge pull request #17 from dmgress/load-template-from-url
69e5a5e 
Fixes #3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmgress dmgress

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmgress