Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove __len__ method from DGLGraph #2902

Merged
merged 5 commits into from
May 11, 2021
Merged

Remove __len__ method from DGLGraph #2902

merged 5 commits into from
May 11, 2021

Conversation

BarclayII
Copy link
Collaborator

PyCharm accesses the __len__ method for every variable during debugging, which will output lots of warning messages for DGLGraph objects. Very uncomfortable.

Fixes #2901 .

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 10, 2021

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@BarclayII BarclayII merged commit 103444c into master May 11, 2021
@BarclayII BarclayII deleted the remove-len branch May 11, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DGLGraph.__len__ completly
3 participants