-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dist] enable USE_EPOLL in default #4167
Conversation
To trigger regression tests:
|
@@ -122,7 +122,8 @@ if(USE_AVX) | |||
endif(USE_LIBXSMM) | |||
endif(USE_AVX) | |||
|
|||
if (USE_EPOLL) | |||
if ((NOT MSVC) AND USE_EPOLL) | |||
INCLUDE(CheckIncludeFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if INCLUDE(CheckIncludeFile)
is not added, error is Unknown CMake command 'check_include_file'
.
@Rhett-Ying Changing to use epoll by default breaks macOS build on either x86_64 or arm64 arch. Line 38 in 9d42531
Temporary measure suggetions:
It's a great idea to use epoll to manage the socketpool but not cross-platform friendly. Is PR open to replace with something else like libuv, or is there another plan? |
Thanks for reporting this. I will fix it. |
@engaineer pls try with the latest master branch... |
Clean build on macOS 12.4 arch arm64 for master with HEAD 1518861. Thanks for being awesome and providing a prompt fix and refinement. |
Description
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes