Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix build issue on mac OS #4175

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Conversation

Rhett-Ying
Copy link
Collaborator

@Rhett-Ying Rhett-Ying commented Jun 28, 2022

Description

follow-up fix for enable USE_EPOLL in default: #4167
fix for #4127

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

Commit ID: 561717a

Build ID: 1

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@@ -124,8 +124,8 @@ endif(USE_AVX)

if ((NOT MSVC) AND USE_EPOLL)
INCLUDE(CheckIncludeFile)
check_include_file("sys/epoll.h" USE_EPOLL)
if (USE_EPOLL)
check_include_file("sys/epoll.h" EPOLL_AVAILABLE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a cmake warning about epoll is not available?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

Commit ID: a758a2a

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

Commit ID: a758a2a

Build ID: 3

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2022

Commit ID: 40dc17e

Build ID: 4

Status: ✅ CI test succeeded

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 1518861 into dmlc:master Jun 28, 2022
@Rhett-Ying Rhett-Ying deleted the useEpollMacOS branch June 28, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants