Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recordio.py #460

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Update recordio.py #460

merged 2 commits into from
Nov 13, 2018

Conversation

kli-casia
Copy link
Contributor

No description provided.

@mli
Copy link
Member

mli commented Nov 8, 2018

Job PR-460-1 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-460/1/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@@ -84,10 +84,10 @@
``~/.mxnet/datasets/imagenet``. You
can specify a different target folder by setting ``--target-dir``.

Read with GluonCV
Read with ImageRecordIter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please extend ---- to match the previous line

@zhreshold
Copy link
Member

@hetong007 Any problem with this PR?

@zhreshold
Copy link
Member

@kli-nlpr Can you address the comments? Just a minor tweak.

@kli-casia
Copy link
Contributor Author

@kli-nlpr Can you address the comments? Just a minor tweak.

@zhreshold I don't know what's the meaning of "extend ----"

@zhreshold
Copy link
Member

@kli-nlpr Append more - to match the length of Read with ImageRecordIter

@kli-casia
Copy link
Contributor Author

@zhreshold finished

@mli
Copy link
Member

mli commented Nov 13, 2018

Job PR-460-3 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-460/3/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@zhreshold zhreshold merged commit aff5c36 into dmlc:master Nov 13, 2018
@zhreshold
Copy link
Member

Thanks, this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants