Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[MAINTENANCE] Move ParallelBigRNN into model api #1118

Merged
merged 5 commits into from
Jan 20, 2020

Conversation

liuzh47
Copy link
Contributor

@liuzh47 liuzh47 commented Jan 16, 2020

Description

There is a class ParallelBigRNN defined in the large_word_language_model.py script. I think it should be merged to the model api like class ParallelTransformer. Additionally, I need to reuse this class in some estimator api.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@liuzh47 liuzh47 requested a review from a team as a code owner January 16, 2020 09:24
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1118 into master will decrease coverage by 0.16%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1118      +/-   ##
==========================================
- Coverage   88.34%   88.18%   -0.17%     
==========================================
  Files          66       66              
  Lines        6290     6306      +16     
==========================================
+ Hits         5557     5561       +4     
- Misses        733      745      +12
Impacted Files Coverage Δ
src/gluonnlp/model/train/language_model.py 88.51% <25%> (-5.27%) ⬇️

@mli
Copy link
Member

mli commented Jan 16, 2020

Job PR-1118/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1118/1/index.html

@mli
Copy link
Member

mli commented Jan 16, 2020

Job PR-1118/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1118/2/index.html

@mli
Copy link
Member

mli commented Jan 16, 2020

Job PR-1118/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1118/3/index.html

@mli
Copy link
Member

mli commented Jan 19, 2020

Job PR-1118/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1118/4/index.html

@mli
Copy link
Member

mli commented Jan 19, 2020

Job PR-1118/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1118/5/index.html

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be good to introduce a test case that runs large_word_language_model.py in this PR or follow-up Estimator PR

@eric-haibin-lin eric-haibin-lin merged commit 912954c into dmlc:master Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants