-
Notifications
You must be signed in to change notification settings - Fork 538
[MAINTENANCE] Move ParallelBigRNN into model api #1118
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
- Coverage 88.34% 88.18% -0.17%
==========================================
Files 66 66
Lines 6290 6306 +16
==========================================
+ Hits 5557 5561 +4
- Misses 733 745 +12
|
Job PR-1118/1 is complete. |
Job PR-1118/2 is complete. |
Job PR-1118/3 is complete. |
Job PR-1118/4 is complete. |
Job PR-1118/5 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be good to introduce a test case that runs large_word_language_model.py
in this PR or follow-up Estimator PR
Description
There is a
class ParallelBigRNN
defined in thelarge_word_language_model.py
script. I think it should be merged to the model api likeclass ParallelTransformer
. Additionally, I need to reuse this class in some estimator api.Checklist
Essentials