Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

rearrange example and test #26

Merged
merged 4 commits into from Apr 18, 2018
Merged

rearrange example and test #26

merged 4 commits into from Apr 18, 2018

Conversation

szhengac
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szhengac szhengac requested a review from szha as a code owner April 18, 2018 21:34
@mli
Copy link
Member

mli commented Apr 18, 2018

Job PR-26/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-26/4/index.html

@szha szha merged commit c48850b into dmlc:master Apr 18, 2018
szha pushed a commit that referenced this pull request Apr 19, 2018
* add scripts test hierarchy and fix lint

* Enable scripts tests

* Enable scripts tests

* Fix lint

* fix makefile

* fix

* fix

* rearrange example and test (#26)

* rearrange example and test

* fix makefile

* fix pylint

* fix docstring

* try test path

* try scripts.*

* fix conflict

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
cgraywang pushed a commit to cgraywang/gluon-nlp-1 that referenced this pull request May 2, 2018
* rearrange example and test

* fix makefile

* fix pylint

* fix docstring
cgraywang pushed a commit to cgraywang/gluon-nlp-1 that referenced this pull request May 2, 2018
* add scripts test hierarchy and fix lint

* Enable scripts tests

* Enable scripts tests

* Fix lint

* fix makefile

* fix

* fix

* rearrange example and test (dmlc#26)

* rearrange example and test

* fix makefile

* fix pylint

* fix docstring

* try test path

* try scripts.*

* fix conflict

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants