Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Change scripts test hierarchy #35

Merged
merged 22 commits into from Apr 19, 2018
Merged

Change scripts test hierarchy #35

merged 22 commits into from Apr 19, 2018

Conversation

szhengac
Copy link
Member

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@szhengac szhengac requested a review from szha as a code owner April 18, 2018 23:42
@leezu leezu mentioned this pull request Apr 19, 2018
Closed
@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/4/index.html

@szha
Copy link
Member

szha commented Apr 19, 2018

Seems that test_bleu wasn't run in the last CI build.

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/5/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/6/index.html

szha
szha reviewed Apr 19, 2018
View reviewed changes
scripts/__init__.py
# under the License.

# pylint: disable=wildcard-import
"""NLP examples."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end with newline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that pylint only complained about the other init files and not this one.

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/7/index.html

szha
szha reviewed Apr 19, 2018
View reviewed changes
Makefile Outdated
@@ -24,7 +24,7 @@ docs:
make -C docs html

test:
nosetests -v --nocapture tests
nosetests -v --nocapture tests scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nosetests -v --nocapture --with-timer scripts/*/test_*.py tests/unittest

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/8/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/9/index.html

szha
szha reviewed Apr 19, 2018
View reviewed changes
Jenkinsfile Outdated
@@ -40,7 +40,7 @@ stage("Unit Test") {
python -m spacy download en
python -m nltk.downloader all
python setup.py install
nosetests -v --nocapture --with-timer tests/unittest
nosetests -v --nocapture --with-timer tests/unittest scripts/tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_bleu.py is still not running. Shall we update the Jenkinsfile with nosetests -v --nocapture --with-timer scripts/*/test_*.py tests/unittest too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange. I remember that it can be run before.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above command works when run locally.. I don't understand why it doesn't run on CI

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/10/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/11 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/11/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/17 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/17/index.html

@szha szha force-pushed the bleu branch 3 times, most recently from 10dcc75 to ba68cac Compare April 19, 2018 05:41
@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/24 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/24/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/25 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/25/index.html

@szha
Copy link
Member

szha commented Apr 19, 2018

Unfortunately the tests in scripts are still not picked up by CI...

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/27 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/27/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/28 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/28/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/29 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/29/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/30 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/30/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/31 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/31/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/32 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/32/index.html

Shuai Zheng added 2 commits April 19, 2018 10:31
@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/33 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/33/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/34 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/34/index.html

@mli
Copy link
Member

mli commented Apr 19, 2018

Job PR-35/35 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-35/35/index.html

@szha szha merged commit 816b387 into dmlc:master Apr 19, 2018
@szhengac szhengac deleted the bleu branch April 19, 2018 18:05
cgraywang pushed a commit to cgraywang/gluon-nlp-1 that referenced this pull request May 2, 2018
@szhengac
Change scripts test hierarchy (dmlc#35)
7ea4540 
* add scripts test hierarchy and fix lint

* Enable scripts tests

* Enable scripts tests

* Fix lint

* fix makefile

* fix

* fix

* rearrange example and test (dmlc#26)

* rearrange example and test

* fix makefile

* fix pylint

* fix docstring

* try test path

* try scripts.*

* fix conflict

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@szha szha szha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szhengac @mli @szha @leezu