Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[FIX] Remove unused code #528

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

Remove an unused line of code

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mli
Copy link
Member

mli commented Jan 7, 2019

Job PR-528/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-528/1/index.html

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b05c2f8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage          ?   70.04%           
=========================================
  Files             ?      122           
  Lines             ?    10462           
  Branches          ?        0           
=========================================
  Hits              ?     7328           
  Misses            ?     3134           
  Partials          ?        0
Flag Coverage Δ
#PR528 70.04% <ø> (?)
#notserial 46.64% <ø> (?)
#py2 69.76% <ø> (?)
#py3 69.9% <ø> (?)
#serial 54.68% <ø> (?)

1 similar comment
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b05c2f8). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #528   +/-   ##
=========================================
  Coverage          ?   70.04%           
=========================================
  Files             ?      122           
  Lines             ?    10462           
  Branches          ?        0           
=========================================
  Hits              ?     7328           
  Misses            ?     3134           
  Partials          ?        0
Flag Coverage Δ
#PR528 70.04% <ø> (?)
#notserial 46.64% <ø> (?)
#py2 69.76% <ø> (?)
#py3 69.9% <ø> (?)
#serial 54.68% <ø> (?)

@szha szha requested a review from cgraywang January 7, 2019 23:21
@eric-haibin-lin eric-haibin-lin merged commit 5577a37 into dmlc:master Jan 8, 2019
@eric-haibin-lin eric-haibin-lin deleted the stream-patch branch May 9, 2019 04:53
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants