Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] fix #579 #678

Merged
merged 1 commit into from Apr 30, 2019
Merged

[DOC] fix #579 #678

merged 1 commit into from Apr 30, 2019

Conversation

szha
Copy link
Member

@szha szha commented Apr 23, 2019

Description

fix #579 by adding warning about trainer.step usage.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • add doc fix

@szha szha requested review from eric-haibin-lin and szhengac and removed request for eric-haibin-lin April 23, 2019 23:19
@mli
Copy link
Member

mli commented Apr 30, 2019

Job PR-678/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-678/8/index.html

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #678 into master will increase coverage by 0.98%.
The diff coverage is 7.47%.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   63.83%   64.81%   +0.98%     
==========================================
  Files         143      144       +1     
  Lines       13467    13253     -214     
==========================================
- Hits         8596     8590       -6     
+ Misses       4871     4663     -208
Flag Coverage Δ
#PR665 ?
#PR669 65.68% <33.33%> (?)
#PR672 64.71% <7.47%> (?)
#PR678 65.06% <7.47%> (?)
#master 65.01% <7.47%> (+1.46%) ⬆️
#notserial 41.57% <4.12%> (+0.29%) ⬆️
#py2 64.53% <7.47%> (+0.94%) ⬆️
#py3 64.62% <7.47%> (+0.91%) ⬆️
#serial 50.94% <5.41%> (+1.03%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #678 into master will increase coverage by 0.98%.
The diff coverage is 7.47%.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   63.83%   64.81%   +0.98%     
==========================================
  Files         143      144       +1     
  Lines       13467    13253     -214     
==========================================
- Hits         8596     8590       -6     
+ Misses       4871     4663     -208
Flag Coverage Δ
#PR665 ?
#PR669 65.68% <33.33%> (?)
#PR672 64.71% <7.47%> (?)
#PR678 65.06% <7.47%> (?)
#master 65.01% <7.47%> (+1.46%) ⬆️
#notserial 41.57% <4.12%> (+0.29%) ⬆️
#py2 64.53% <7.47%> (+0.94%) ⬆️
#py3 64.62% <7.47%> (+0.91%) ⬆️
#serial 50.94% <5.41%> (+1.03%) ⬆️

@szha szha merged commit 708d46a into master Apr 30, 2019
@szha szha deleted the szha-patch-1 branch April 30, 2019 21:20
gigasquid pushed a commit to gigasquid/gluon-nlp that referenced this pull request May 6, 2019
astonzhang pushed a commit that referenced this pull request May 10, 2019
paperplanet pushed a commit to paperplanet/gluon-nlp that referenced this pull request Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clip_grad_global_norm doc needs notice on usage (was: clip_grad_global_norm produces problematic results)
4 participants