Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature importances for DART booster not available via sklearn interface #4497

Closed
Ewande opened this issue May 24, 2019 · 1 comment · Fixed by #4525
Closed

Feature importances for DART booster not available via sklearn interface #4497

Ewande opened this issue May 24, 2019 · 1 comment · Fixed by #4525

Comments

@Ewande
Copy link

Ewande commented May 24, 2019

This bug was fixed in Booster.get_score (see #4073) but it's still present in sklearn.py

if getattr(self, 'booster', None) is not None and self.booster != 'gbtree':

vs
if getattr(self, 'booster', None) is not None and self.booster not in {'gbtree', 'dart'}:

It would make sense to remove that condition from sklearn.py, since an exception will be raised from Booster.get_score anyway.

@hcho3
Copy link
Collaborator

hcho3 commented May 31, 2019

See #4525

@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants