Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mingw64 installation instruction, and library file copy. #2977

Merged
merged 2 commits into from Feb 9, 2018
Merged

added mingw64 installation instruction, and library file copy. #2977

merged 2 commits into from Feb 9, 2018

Conversation

cinqs
Copy link
Contributor

@cinqs cinqs commented Dec 26, 2017

with regards to #2928

@codecov-io
Copy link

codecov-io commented Dec 26, 2017

Codecov Report

Merging #2977 into master will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2977     +/-   ##
===========================================
+ Coverage     43.19%   43.79%   +0.6%     
- Complexity      207      228     +21     
===========================================
  Files           155      159      +4     
  Lines         11614    12507    +893     
  Branches       1161      466    -695     
===========================================
+ Hits           5017     5478    +461     
- Misses         6267     6837    +570     
+ Partials        330      192    -138
Impacted Files Coverage Δ Complexity Δ
src/objective/objective.cc 66.66% <0%> (-24.25%) 0% <0%> (ø)
src/tree/tree_updater.cc 47.36% <0%> (-14.18%) 0% <0%> (ø)
src/gbm/gbm.cc 26.66% <0%> (-10.84%) 0% <0%> (ø)
include/xgboost/objective.h 30.76% <0%> (-9.24%) 0% <0%> (ø)
src/metric/rank_metric.cc 85.06% <0%> (-5.75%) 0% <0%> (ø)
src/tree/param.h 59.45% <0%> (-4.05%) 0% <0%> (ø)
...c/xgboost4j/scala/spark/params/GeneralParams.scala 92.59% <0%> (-2.65%) 0% <0%> (ø)
src/common/math.h 60.71% <0%> (-2.25%) 0% <0%> (ø)
src/gbm/gbtree.cc 18.05% <0%> (-2.08%) 0% <0%> (ø)
include/xgboost/gbm.h 12.5% <0%> (-1.79%) 0% <0%> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6673c...7fbe0f4. Read the comment docs.

@hcho3
Copy link
Collaborator

hcho3 commented Feb 9, 2018

Thanks for your PR. I took time to read through Makefile and CMakeLists.txt and found out that we indeed get xgboost.dll, not libxgboost.dll as described in the documentation. I'll go ahead and remove all references to libxgboost.dll.

On Windows, the library file is called `xgboost.dll`, not `libxgboost.dll` as in the build doc previously
@hcho3
Copy link
Collaborator

hcho3 commented Feb 9, 2018

I'll merge this once the tests are completed.

@hcho3 hcho3 merged commit b99f56e into dmlc:master Feb 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants