-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable xgb_model in scklearn XGBClassifier and test. #4092
Conversation
test for xgb_model parameter in XGBClassifier API.
Enable xgb_model parameter in XGClassifier scikit-learn API
@hcho3 Have you encountered the failed lightweight tests like this one before? |
@trivialfis I think it is a formatting issue. In line 613 of test_with_sklearn.py, we need to add one extra empty line there. |
Codecov Report
@@ Coverage Diff @@
## master #4092 +/- ##
=======================================
Coverage 60.56% 60.56%
=======================================
Files 130 130
Lines 11756 11756
=======================================
Hits 7120 7120
Misses 4636 4636
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll go ahead and merge. Thanks for your contribution.
Enable xgb_model parameter in XGClassifier scikit-learn API & test in one PR.
Fixes #3049.