New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] Remove duplicated predict functions, Fix attributes IO. #6593
Conversation
e97749b
to
cf7660a
Compare
This PR is only breaking for the users who specified the |
Yes. |
@hcho3 This turned up to be another fix for attributes like Update: Didn't recall that these things are not supposed to be saved. Worked on saving booster feature names and types. Need some time to get it done as removing feature name generation breaks quite a few things. |
* Fix attributes not being restored. * Rename all `data` to `X`. [breaking]
b2c9613
to
a2635af
Compare
Codecov Report
@@ Coverage Diff @@
## master #6593 +/- ##
==========================================
- Coverage 80.44% 80.33% -0.12%
==========================================
Files 13 13
Lines 3657 3656 -1
==========================================
- Hits 2942 2937 -5
- Misses 715 719 +4
Continue to review full report at Codecov.
|
data
toX
. [breaking]