Add base_margin for evaluation dataset. #6591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
eval_set_base_margin
branch
from
116aada
to
e905321
Compare
|
Note to myself: Compile a list of entry points of meta info. |
trivialfis
force-pushed
the
eval_set_base_margin
branch
2 times, most recently
from
d101a6b
to
273da8e
Compare
|
@hcho3 CI seems to be running into trouble. ;-( |
|
@trivialfis Can you fix this error? |
|
Yup, I will be working on this today. |
hcho3
reviewed
Jan 12, 2021
trivialfis
force-pushed
the
eval_set_base_margin
branch
from
c43532b
to
836edf2
Compare
hcho3
reviewed
Jan 12, 2021
|
Since I have spited this PR into smaller part in #6601 and will continue to do so for better review, I will add links to related PRs. |
* Add base margin to evaluation datasets. * Unify the code base for evaluation matrices.
trivialfis
force-pushed
the
eval_set_base_margin
branch
from
836edf2
to
c1cbc4c
Compare
|
Added a test for avoiding duplicated DMatrix after rebasing. |
|
@hcho3 Ready for another round of review. |
hcho3
approved these changes
Jan 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #6591 +/- ##
==========================================
+ Coverage 80.95% 80.98% +0.03%
==========================================
Files 13 13
Lines 3696 3676 -20
==========================================
- Hits 2992 2977 -15
+ Misses 704 699 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6583 .
Close #6300 .
base_marginto evaluation dataset in skl.DMatrixconstructor, and deprecate the pos arguments.I will split up this mono PR after getting all the pieces together. With growing size of meta info, I need to do some refactoring.
Small parts are extracted to: