Define metainfo for all DMatrix interfaces. #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
dmatrix-metainfo
branch
2 times, most recently
from
719dbb3
to
b21a3a4
Compare
trivialfis
requested review from
RAMitchell and
hcho3
and removed request for
RAMitchell
Codecov Report
@@ Coverage Diff @@
## master #6601 +/- ##
==========================================
- Coverage 81.13% 80.08% -1.06%
==========================================
Files 13 13
Lines 3679 3675 -4
==========================================
- Hits 2985 2943 -42
- Misses 694 732 +38
Continue to review full report at Codecov.
|
trivialfis
force-pushed
the
dmatrix-metainfo
branch
from
70be2f4
to
1a2f548
Compare
hcho3
requested changes
Jan 21, 2021
There was a problem hiding this comment.
Please address my comment at #6591 (comment). You should choose between two alternatives:
- Break backward compatibility now. This might be reasonable choice if it's necessary to unity Dask and non-Dask interfaces; OR
- Don't break backward compatibility now; only add deprecation warning. For this alternative, all new parameters should only be added at the end of each function, not in the middle, to avoid breaking existing code using positional args.
My review below assumes that you've chosen Option 2. Let me know if you want to go with Option 1.
I will try to avoid breaking the compatibility. |
trivialfis
force-pushed
the
dmatrix-metainfo
branch
from
1a2f548
to
4884b97
Compare
|
@hcho3 I limited the breaking changes to |
This PR ensures all DMatrix types have a common interface. * Check for consistency between DMatrix types. * Add doc for bounds.
trivialfis
force-pushed
the
dmatrix-metainfo
branch
from
4884b97
to
85930fc
Compare
hcho3
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small part extracted from #6591 to ease reviewing.