Optional find dependency in installed cmake config. #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
cmake-install-targets
branch
from
dd58299
to
1280fa5
Compare
Codecov Report
@@ Coverage Diff @@
## master #7099 +/- ##
=======================================
Coverage 81.59% 81.59%
=======================================
Files 13 13
Lines 3901 3901
=======================================
Hits 3183 3183
Misses 718 718 Continue to review full report at Codecov.
|
trivialfis
commented
Jul 11, 2021
| @@ -4,7 +4,7 @@ find_package(Threads REQUIRED) | |||
|
|
|||
| set(RABIT_SOURCES | |||
| ${CMAKE_CURRENT_LIST_DIR}/src/allreduce_base.cc | |||
| ${CMAKE_CURRENT_LIST_DIR}/src/c_api.cc) | |||
| ${CMAKE_CURRENT_LIST_DIR}/src/rabit_c_api.cc) | |||
There was a problem hiding this comment.
msvc complains that 2 files having same name might produce incorrect result. So I renamed the c api file and merged the test_io.cc into xgboost.
hcho3
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #6159 . This PR removes
find_dependencyin CMake config and make sure dependencies are private if xgboost is built as shared library (the default).An issue was found during writing another C demo for external memory, where I have to set the project with
CXXlanguage to get CMake working (but I'm writing a demo for C). AlsoFindNcclis a custom script in xgboost which is not available as part of CMake, adding it to dependency will break users' code.After the PR we simply include gputreeshap header instead of linking it due to a CMake error saying it's not in the export set when built as a static library.
Other than these, I added a simple script using
readelfto show that the C demo is not linking anything from the dependency set of xgboost.