VM-Packages: Auto-detection of MUSL is replaced by system properties #7921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te class In a subsequent commit, this class will check whether a system property is set which overrides the name. And this can then easily be tested.
If the property xgboostruntime.native.<libName> is present, we are using the value of this property as library path for the library libName. No other processing is done.
In this case, the user now sees an error message suggesting to manually set the library path of the native library via a specific system property.
As this does not work in all scenarios anyway, we can get rid of this logic here. Instead, a user using a MUSL-based Linux system can now specify the exact path to the native library via a system property.
Craigacp
reviewed
May 19, 2022
jvm-packages/xgboost4j/src/main/java/ml/dmlc/xgboost4j/java/NativeLibLoader.java
Show resolved
Hide resolved
trivialfis
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes auto-detection of MUSL-based Linux systems in favor of system properties the user can set to configure a specific path for a native library.
At the moment, there's only a single library with the name
xgboost4jthat we need. A user who wants to configure a specific path, has to set the system propertyxgboostruntime.native.xgboost4j. If this system property is present, its value is used as a library path inside the JAR.A user who runs xgboost4j on a MUSL-based Linux system, will get an additional error message
Alternatively, if your Linux OS is musl-based, you should set the path for the native library xgboost4j via the system property xgboostruntime.native.xgboost4j.Resolves #7915