[pyspark] Handle the device parameter in pyspark.
#9390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @WeichenXu123 . |
|
emm, @trivialfis This is a breaking change, it breaks our customer code unexpectedly, can we just deprecate |
- Handle the new `device` parameter in pyspark. - Remove the old `use_gpu` parameter. py3.8 Convert some tests. lint. linter is happy. Early validation. Fix test.
trivialfis
force-pushed
the
device-ordinal-pyspark
branch
from
99a4390
to
9b57a90
Compare
trivialfis
changed the title
device parameter in pyspark.device parameter in pyspark.
|
@WeichenXu123 Restored the compatibility with a warning when |
python-package/xgboost/spark/core.py
Outdated
| use_gpu = Param( | ||
| Params._dummy(), | ||
| "use_gpu", | ||
| "A boolean variable. Set use_gpu=true if the executors " | ||
| + "are running on GPU instances. Currently, only one GPU per task is supported.", | ||
| "Deprecated, use `device` instead.", |
There was a problem hiding this comment.
Let's keep original doc but append Deprecated
There was a problem hiding this comment.
Done, the notice is prepended.
RAMitchell
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deviceparameter in pyspark.use_gpuparameter.