-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking deprecated features. #3986
Comments
Inspired by @thvasilo in #3929 (Thanks). Let's keep track of deprecated features here. Great chance that I missed something, anyone who notice please help adding it back. :) @hcho3 Please help filling the |
Let's discuss whether |
@hcho3 I tried to find out what it does. It turns out |
Its always 1 in code. According to @tqchen it was intended to be used for multiclass trees (he can maybe confirm this). There is also something in metainfo to do with root index that is not documented or used - suggest also deprecating this. |
I think it is fine dropping them, but let us also keep the backward compatibility in mind. It might be useful to first introduce json exchange format, and then allow upgrade via json |
@trivialfis Why is @tqchen Got it |
Just found out that xgboost/include/xgboost/tree_model.h Line 34 in 3d81c48
This field is different from the Line 29 in 42bf90e
Every occurrence of It is not possible to remove |
Yes, JSON is the priority. This issue is intended to be long term tracking.
No idea. The document said so: xgboost/include/xgboost/c_api.h Line 187 in 42bf90e
|
@hcho3 I'm only tracking the features that's already decided to be deprecated here, so that we can have a time frame for removing those code, as you can see some of them are really old and still lingering. Let's move whether some other features needed to be deprecated into new issues. :) |
Got it. I'll file a new issue to deprecate
Turns out |
There's an issue on the board about |
grow_fast_histmaker
grow_quantile_histmaker
.R/xgb.importance.R
.num_pbuffer_deprecated
python/training.py: train::learning_rates
python/sklearn.py: seed
python/sklearn.py: nthread
XGDMatrixCreateFromCSC
XGDMatrixCreateFromCSCEx
XGDMatrixCreateFromCSR
XGDMatrixCreateFromCSR_omp
silent
verbosity
gpu_exact
hist
orapprox
on GPU.n_gpus
dask
orspark
reg:linear
reg:squarederror
XGDMatrixSetGroup
XGDMatrixSetUIntInfo
instead.TreeParam.max_depth
XGBClassifier
(use_label_encoder=True
)ntree_limit
in Pythoniteration_range
or model slicing instead.use_gpu
in PySparkdevice
instead.gpu_hist
tree methoddevice
instead.gpu_coord_descent
updaterdevice
instead.predictor
(cpu_predictor
,gpu_predictor
)device
instead.gpu_id
tree methoddevice
instead.fit
parameters in the sklearn interfaceset_params
instead.XGDMatrixSetDenseInfo
XGDMatrixSetInfoFromInterface
manylinux2014
Python wheelsmanylinux2_28
wheels insteadThe text was updated successfully, but these errors were encountered: