Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Set up CI for Mac M1 #9699

Merged
merged 13 commits into from
Oct 23, 2023
Merged

[CI] Set up CI for Mac M1 #9699

merged 13 commits into from
Oct 23, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Oct 22, 2023

For now, ensure that XGBoost can be built with Clang 11 on Mac M1. This particular combination has given us trouble before (#9684).

@hcho3 hcho3 changed the title [CI] [WIP] Set up CI for Mac M1 [CI] Set up CI for Mac M1 Oct 22, 2023
@hcho3 hcho3 requested a review from trivialfis October 22, 2023 06:49
@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 22, 2023

@trivialfis This PR is now ready for review. The new CI pipeline will ensure that XGBoost will be compatible with MacOS M1.

- cffi
- pyarrow
- pyspark>=3.4.0
- cloudpickle
- pip:
- sphinx_rtd_theme
- datatable
- py-ubjson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any difficulty installing it from conda-forge?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Conda-forge doesn't yet offer py-ujson for Apple M1.

@hcho3 hcho3 merged commit 5e6cb63 into dmlc:master Oct 23, 2023
25 of 28 checks passed
@trivialfis
Copy link
Member

clang11 seems quite old though. not sure if the apple-clang is in sync with clang when it comes to versioning.

@hcho3 hcho3 deleted the mac_m1_ci branch October 23, 2023 06:33
@hcho3
Copy link
Collaborator Author

hcho3 commented Oct 23, 2023

I plan to add latest appleclang in a follow-up PR

@trivialfis
Copy link
Member

The CI for macos is failing on master and on PR. The failure seems to happen right after mamba installs packages.

hcho3 added a commit to hcho3/xgboost that referenced this pull request Dec 14, 2023
hcho3 added a commit that referenced this pull request Dec 14, 2023
* [CI] Set up CI for Mac M1 (#9699)

* [CI] Improve CI for Mac M1 (#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (#9886)
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Dec 19, 2023
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880)

* [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879)

* [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887)

* [CI] Set up CI for Mac M1 (dmlc#9699)

* [CI] Improve CI for Mac M1 (dmlc#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886)

* [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Bump version to 2.0.3 (dmlc#9895)

* Update change_scala_version.py to also change scala.version property (dmlc#9897)

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request May 15, 2024
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880)

* [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879)

* [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887)

* [CI] Set up CI for Mac M1 (dmlc#9699)

* [CI] Improve CI for Mac M1 (dmlc#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886)

* [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Bump version to 2.0.3 (dmlc#9895)

* Update change_scala_version.py to also change scala.version property (dmlc#9897)

* [backport] Fix compiling with the latest CTX. (dmlc#10263)

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants