Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update change_scala_version.py to also change scala.version property #9897

Merged
merged 8 commits into from Dec 19, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Dec 15, 2023

Follow up to #9893

The script change_scala_version.py should also update the scala.version property, since the user may not be use the profile scala-2.12 when running Maven.

cc @trivialfis @wbo4958

@trivialfis
Copy link
Member

I'm not familiar with the ecosystem and cannot comment on this.

@wbo4958
Copy link
Contributor

wbo4958 commented Dec 15, 2023

I got below error using the script.

sh.ErrorReturnCode_2: 

  RAN: /usr/bin/sed -i 's/<artifactId>xgboost-jvm_[0-9\.]*/<artifactId>xgboost-jvm_2.13/g' -e 's/<artifactId>xgboost-jvm_[0-9\.]*/<artifactId>xgboost-jvm_2.13/g' -e '0,/<scala.version>/ s/<scala.version>[0-9\.]*/<scala.version>2.13.11/' -e '0,/<scala.binary.version>/ s/<scala.binary.version>[0-9\.]*/<scala.binary.version>2.13/' jvm-packages/pom.xml

  STDOUT:


  STDERR:
/usr/bin/sed: can't read s/<artifactId>xgboost-jvm_[0-9\.]*/<artifactId>xgboost-jvm_2.13/g: No such file or direct

@hcho3
Copy link
Collaborator Author

hcho3 commented Dec 15, 2023

Are you using a Mac? I was able to run the script on a Ubuntu box without any issue.

@wbo4958
Copy link
Contributor

wbo4958 commented Dec 15, 2023

I was using Ubuntu to do the test

@hcho3
Copy link
Collaborator Author

hcho3 commented Dec 15, 2023

@wbo4958 Can you try again with the updated script?

@wbo4958
Copy link
Contributor

wbo4958 commented Dec 18, 2023

It can work. But I'm curious seems it only updated the xgboost_jvm instead of updating the sub modules,

For example, the artifactId in xgboost4j-spark has not been changed, is that expected?

<artifactId>xgboost4j-spark_${scala.binary.version}</artifactId>

@hcho3 hcho3 merged commit 82d846b into dmlc:release_2.0.0 Dec 19, 2023
22 of 26 checks passed
@hcho3 hcho3 deleted the fix_scala_script branch December 19, 2023 07:49
razdoburdin added a commit to IntelPython/xgboost_oneapi that referenced this pull request Dec 19, 2023
* [backport][sklearn] Fix loading model attributes. (dmlc#9808) (dmlc#9880)

* [backport][py] Use the first found native library. (dmlc#9860) (dmlc#9879)

* [backport] [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9887)

* [CI] Set up CI for Mac M1 (dmlc#9699)

* [CI] Improve CI for Mac M1 (dmlc#9748)

* [CI] Build libxgboost4j.dylib with CMAKE_OSX_DEPLOYMENT_TARGET (dmlc#9749)

* [CI] Upload libxgboost4j.dylib (M1) to S3 bucket (dmlc#9886)

* [jvm-packages] Fix POM for xgboost-jvm metapackage (dmlc#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Bump version to 2.0.3 (dmlc#9895)

* Update change_scala_version.py to also change scala.version property (dmlc#9897)

---------

Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
hcho3 added a commit that referenced this pull request Jan 12, 2024
* [jvm-packages] Add Scala version suffix to xgboost-jvm package (#9776)

* Update JVM script (#9714)

* Revamp pom.xml

* Update instructions in prepare_jvm_release.py

* Fix formatting

* [jvm-packages] Fix POM for xgboost-jvm metapackage (#9893)

* [jvm-packages] Fix POM for xgboost-jvm metapackage

* Add script for updating the Scala version

* Update change_scala_version.py to also change scala.version property (#9897)

* Remove 'release-cpu-only' profile

* Remove scala-2.13 profile; enable gpu package for Scala 2.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants