Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handler to report celery exception errors #102

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

hinashi
Copy link
Contributor

@hinashi hinashi commented Mar 26, 2021

Email settings are required.
If there is no mail setting, it will not be processed.

Copy link
Contributor

@takano32 takano32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@userlocalhost userlocalhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your good work!

It's better to make a test to confirm that an e-mail that has expected context will be dispatched when some exception is happened at celery process. But it's much difficult for now. So I made an issue #115.

@@ -14,3 +16,24 @@

# Load task modules from all registered Django app configs.
app.autodiscover_tasks()


@task_failure.connect()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@userlocalhost userlocalhost merged commit 843c607 into dmm-com:master Apr 17, 2021
@hinashi hinashi deleted the feature/celery/error_report branch May 10, 2021 01:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants