New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis output sink #1

Merged

dmmulroy merged 27 commits into develop from redis-output-sink

May 18, 2020

Owner

dmmulroy commented May 8, 2020

No description provided.

sklose reviewed

View reviewed changes

packages/redis/src/RedisProxy.ts Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/index.ts Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Outdated Show resolved Hide resolved

sklose commented May 8, 2020

we should also add some end-to-end integration tests for this (might be easier once you have the source implemented as well) ... if i am not mistaken the develop branch already has integration tests for redis that can run in CI and that you can easily add to

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Show resolved Hide resolved


          Squashed commit of the following:

3faedf2

commit c3a29aa
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Fri May 8 15:27:35 2020 -0400

    small syntax change

commit a723328
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Fri May 8 15:11:15 2020 -0400

    move exported enum

commit c666f5a
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Fri May 8 15:03:31 2020 -0400

    minor code changes

commit 6243206
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Fri May 8 15:01:36 2020 -0400

    add guarantees

commit c6e79c9
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Thu May 7 16:46:34 2020 -0400

    wrap up initial sink

commit c68e637
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Thu May 7 16:28:34 2020 -0400

    wip

commit 55add1a
Author: Dillon Mulroy <dillon.mulroy@formidable.com>
Date:   Thu May 7 13:37:37 2020 -0400

    intial sink + types

dmmulroy force-pushed the redis-output-sink branch from c3a29aa to 3faedf2 Compare

May 11, 2020 15:35

dmmulroy changed the base branch from master to develop

May 11, 2020 15:35

dmmulroy added 8 commits

May 11, 2020 14:07


          update comment

e86c904


          fix type error

9bbe879


          spacing

631111d


          remove lockfile


          remove lock files

37552db


          remove lock files


          update sink w/ new retry logic

49f0512


          add tests

419c0aa

Owner Author

dmmulroy commented May 12, 2020

All comments are resolved and tests have been added


          fix type def

e15a0e9

sklose reviewed

View reviewed changes

packages/redis/package.json Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisClient.ts Outdated Show resolved Hide resolved

sklose reviewed

View reviewed changes

packages/redis/src/RedisStreamSink.ts Show resolved Hide resolved


          remove jest from deps

f767a43

sklose reviewed

View reviewed changes

packages/redis/src/__test__/redisClient.integration.test.ts Outdated Show resolved Hide resolved

dmmulroy added 4 commits

May 13, 2020 16:42


          fix spanning

2f5a162


          remove enum exports from RedisClient

f1a8ae4


          create redisStremSink factory function

47715fc


          change wording of test

6ae7c4d

dmmulroy added 8 commits

May 13, 2020 18:20


          work on e2e test

3d0b9d9


          port xread type

62b7d45


          port xread result type

66bdec8


          port xread result type

bc5f51a


          Merge branch 'redis-output-sink' of github.com:dmmulroy/cookie-cutter…

0c5a77e

… into redis-output-sink


          wip on e2e integration tests

a56de94


          add working e2e test

d443c19


          improve e2e integration test

70c9e76

chrnola reviewed

View reviewed changes

packages/redis/src/RedisClient.ts Outdated Show resolved Hide resolved

dmmulroy added 4 commits

May 14, 2020 17:03


          move encoding/decoding to client layer

bae7290


          integrate base64Encode config option

a0f0400


          update xAdd to store buffers

6a62b8d


          update test + getObject

0cce9cb

dmmulroy merged commit 24a883a into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet