Fix broken "npm install" and memory leaks #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for npm install to work properly
- use 'src_set_ratio' to prevent smooth transition and concurrent reset - use private member 'src_ratio' to remember target ratio in case that more than two stream exist
- rebuild on npm install, to avoid errors
nanokina
changed the title
- Because Travis CI told me to
|
Test passed! 🎉 |
|
For anyone interested in using this library nowadays, I made a fork of nanokina's repository addressing issues in building and also removing https://github.com/ThePedroo/node-libsamplerate I don't plan to create a PR to fix those issues, but if the repository maintainer sees this, feel free to commit my fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dmooney65
First of all thanks for making the nice addon we are using this on a bot
But I ended up facing several problems, so I had to fix them
npm install node-libsamplerateno longer works properly, (supposedly) due to CMake-JS changed the manner of use of it.src_ratiorelated problem when two or more input streams exist on an event loop and their input samplerates varies (so do the ratios, of course).Anyways, hope you can take a look at it 😄