Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density upload column reordering #6

Closed
MarkTrinder opened this issue Dec 4, 2018 · 6 comments
Closed

Density upload column reordering #6

MarkTrinder opened this issue Dec 4, 2018 · 6 comments

Comments

@MarkTrinder
Copy link

I think the upload density option is rearranging months alphabetically - I just uploaded Distribution samples but couldn't understand the weird results until I re-ordered the upload data!
Don't know if this will also apply to the Distribution reference points but I guess thats possible?!

@MarkTrinder
Copy link
Author

more...
I tried re-ordering the columns of my density data to get them in the 'right' sequence, which I seem to have achieved ok, but the results for each month were mixed up again. So I have run the model using the apparently wrong month order for densities and this seems to be giving the right answers! So the month re-ordering seems to just be the plots of input densities, but the actual model is treating them in the right order.

To illustrate, here are the input densities as plotted (wrongly):
image

and here are the option2 outputs (in correct order):
image

these should follow the same pattern!

@bcaneco
Copy link
Member

bcaneco commented Dec 7, 2018

Hi Mark,
Yes, indeed, that's a bug in the code!
Upon checking, the cheeky bug is sitting on the chuck of code producing the input density plots, on both the distribution samples and reference points. However, the input data is entered in the model correctly on both cases.

The bug has been squashed in the development code and the issue will be resolved upon the next version release, which will hopefully be out soon.

Thanks for spotting it!

@MarkTrinder
Copy link
Author

MarkTrinder commented Jan 24, 2019 via email

@bcaneco
Copy link
Member

bcaneco commented Jan 25, 2019

Hi Mark, I've just uploaded the repository with an updated version of the app (v2.2.2), where this issue should be resolved. It's really just a quick patch to fix the bug, as a fresher version with additional features (mainly focussed on user support, e.g. storing and restoring input values) will be released in a not too distant future.

Thanks for your help.

@MarkTrinder
Copy link
Author

MarkTrinder commented Jan 25, 2019 via email

bcaneco added a commit that referenced this issue Feb 11, 2019
(i) storing-restoring inputs; (ii) logos added; (iii) check on NAs and missing data; (iv) default species biometrics; (v) issues posted gitHub addressed Closes #2 #3 #6 #8 (vi) session-specific output folders and files
@bcaneco
Copy link
Member

bcaneco commented Feb 14, 2019

Closing issue as bug fixed

@bcaneco bcaneco closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants