Alerts #136
Merged
Alerts #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huddlej: I am not exactly sure how to phrase the alert messages so any comments you have there would be especially helpful! |
huddlej
approved these changes
May 9, 2020
There was a problem hiding this comment.
The alert messages are great and the display on error looks great, too! I pushed a change to use the error alert class ("danger") just to make it clearer to users than something really bad has happened instead of something they could potentially ignore (a warning).
Do you want me to rebase this onto master now that we've merged the protein structure refactor branch?
|
Great! And yes that sounds good! |
Updates the alert class to make it clearer to users than an error has occurred where the previous colors indicated a warning (something less actionable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces alert fields when a URL fails to load correctly. The alert tells the user to check the URL or check the documentation. The alerts are hidden by default and hide again when a valid URL/datafile is entered.
This PR is rebased with the refactor-polymer-select-dropdown branch.